[8.16] [Dataset Quality] Fix failing test on mki qa (#196122)#196816
Merged
achyutjhunjhunwala merged 2 commits intoelastic:8.16from Oct 18, 2024
Merged
[8.16] [Dataset Quality] Fix failing test on mki qa (#196122)#196816achyutjhunjhunwala merged 2 commits intoelastic:8.16from
achyutjhunjhunwala merged 2 commits intoelastic:8.16from
Conversation
## Summary Closes elastic#195466 As LogDB mode is enabled on MKI QA environment, it causes mappings for certain fields like `host.name` to be set differently. Hence causing tests to fail. As part of the fix, before ingesting data, i am statically setting the mappings so that it does not cause any collision with something outside the scope of the tests (cherry picked from commit 7237902) # Conflicts: # x-pack/test/api_integration/deployment_agnostic/apis/observability/dataset_quality/degraded_field_analyze.ts # x-pack/test_serverless/functional/test_suites/observability/dataset_quality/degraded_field_flyout.ts
botelastic
Bot
added
ci:project-deploy-observability
Contributor
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
Contributor
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
yngrdyn
approved these changes
Oct 18, 2024
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Public APIs missing comments
History
|
achyutjhunjhunwala
added a commit
that referenced
this pull request
Oct 23, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [[Dataset Quality] Fix failing test on mki qa (#196122)](#196122) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Achyut Jhunjhunwala","email":"achyut.jhunjhunwala@elastic.co"},"sourceCommit":{"committedDate":"2024-10-14T19:19:10Z","message":"[Dataset Quality] Fix failing test on mki qa (#196122)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/195466\r\n\r\nAs LogDB mode is enabled on MKI QA environment, it causes mappings for\r\ncertain fields like `host.name` to be set differently. Hence causing\r\ntests to fail.\r\n\r\nAs part of the fix, before ingesting data, i am statically setting the\r\nmappings so that it does not cause any collision with something outside\r\nthe scope of the tests","sha":"7237902fad6424d9556cff78e3f3ac7e62fa4bac","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-logs","Team:obs-ux-infra_services","Feature:Dataset Health","apm:review","v8.16.0"],"number":196122,"url":"https://github.com/elastic/kibana/pull/196122","mergeCommit":{"message":"[Dataset Quality] Fix failing test on mki qa (#196122)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/195466\r\n\r\nAs LogDB mode is enabled on MKI QA environment, it causes mappings for\r\ncertain fields like `host.name` to be set differently. Hence causing\r\ntests to fail.\r\n\r\nAs part of the fix, before ingesting data, i am statically setting the\r\nmappings so that it does not cause any collision with something outside\r\nthe scope of the tests","sha":"7237902fad6424d9556cff78e3f3ac7e62fa4bac"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196122","number":196122,"mergeCommit":{"message":"[Dataset Quality] Fix failing test on mki qa (#196122)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/195466\r\n\r\nAs LogDB mode is enabled on MKI QA environment, it causes mappings for\r\ncertain fields like `host.name` to be set differently. Hence causing\r\ntests to fail.\r\n\r\nAs part of the fix, before ingesting data, i am statically setting the\r\nmappings so that it does not cause any collision with something outside\r\nthe scope of the tests","sha":"7237902fad6424d9556cff78e3f3ac7e62fa4bac"}},{"branch":"8.x","label":"v8.16.0","labelRegex":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"url":"https://github.com/elastic/kibana/pull/196816","number":196816,"branch":"8.16","state":"MERGED","mergeCommit":{"sha":"d7bbd0adf3108fc00dddf361bc4d7840ded5dc8f","message":"[8.16] [Dataset Quality] Fix failing test on mki qa (#196122) (#196816)\n\n# Backport\n\nThis will backport the following commits from `main` to `8.16`:\n- [[Dataset Quality] Fix failing test on mki qa\n(#196122)](https://github.com/elastic/kibana/pull/196122)\n\n<!--- Backport version: 8.9.8 -->\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT [{\"author\":{\"name\":\"Achyut\nJhunjhunwala\",\"email\":\"achyut.jhunjhunwala@elastic.co\"},\"sourceCommit\":{\"committedDate\":\"2024-10-14T19:19:10Z\",\"message\":\"[Dataset\nQuality] Fix failing test on mki qa (#196122)\\n\\n##\nSummary\\r\\n\\r\\nCloses\nhttps://github.com//issues/195466\\r\\n\\r\\nAs LogDB mode is\nenabled on MKI QA environment, it causes mappings for\\r\\ncertain fields\nlike `host.name` to be set differently. Hence causing\\r\\ntests to\nfail.\\r\\n\\r\\nAs part of the fix, before ingesting data, i am statically\nsetting the\\r\\nmappings so that it does not cause any collision with\nsomething outside\\r\\nthe scope of the\ntests\",\"sha\":\"7237902fad6424d9556cff78e3f3ac7e62fa4bac\",\"branchLabelMapping\":{\"^v9.0.0$\":\"main\",\"^v8.16.0$\":\"8.x\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"release_note:skip\",\"backport\nmissing\",\"v9.0.0\",\"backport:prev-minor\",\"ci:project-deploy-observability\",\"Team:obs-ux-logs\",\"Team:obs-ux-infra_services\",\"Feature:Dataset\nHealth\",\"apm:review\"],\"number\":196122,\"url\":\"https://github.com/elastic/kibana/pull/196122\",\"mergeCommit\":{\"message\":\"[Dataset\nQuality] Fix failing test on mki qa (#196122)\\n\\n##\nSummary\\r\\n\\r\\nCloses\nhttps://github.com//issues/195466\\r\\n\\r\\nAs LogDB mode is\nenabled on MKI QA environment, it causes mappings for\\r\\ncertain fields\nlike `host.name` to be set differently. Hence causing\\r\\ntests to\nfail.\\r\\n\\r\\nAs part of the fix, before ingesting data, i am statically\nsetting the\\r\\nmappings so that it does not cause any collision with\nsomething outside\\r\\nthe scope of the\ntests\",\"sha\":\"7237902fad6424d9556cff78e3f3ac7e62fa4bac\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[],\"targetPullRequestStates\":[{\"branch\":\"main\",\"label\":\"v9.0.0\",\"labelRegex\":\"^v9.0.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/196122\",\"number\":196122,\"mergeCommit\":{\"message\":\"[Dataset\nQuality] Fix failing test on mki qa (#196122)\\n\\n##\nSummary\\r\\n\\r\\nCloses\nhttps://github.com//issues/195466\\r\\n\\r\\nAs LogDB mode is\nenabled on MKI QA environment, it causes mappings for\\r\\ncertain fields\nlike `host.name` to be set differently. Hence causing\\r\\ntests to\nfail.\\r\\n\\r\\nAs part of the fix, before ingesting data, i am statically\nsetting the\\r\\nmappings so that it does not cause any collision with\nsomething outside\\r\\nthe scope of the\ntests\",\"sha\":\"7237902fad6424d9556cff78e3f3ac7e62fa4bac\"}}]}] BACKPORT-->"}}]}] BACKPORT-->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.16:Questions ?
Please refer to the Backport tool documentation