Skip to content

[8.x] fix no-restricted-imports (#195456)#196517

Merged
Dosant merged 5 commits intoelastic:8.xfrom
Dosant:backport/8.x/pr-195456
Oct 17, 2024
Merged

[8.x] fix no-restricted-imports (#195456)#196517
Dosant merged 5 commits intoelastic:8.xfrom
Dosant:backport/8.x/pr-195456

Conversation

@Dosant
Copy link
Copy Markdown
Contributor

@Dosant Dosant commented Oct 16, 2024

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

@Dosant
fix no-restricted-imports (elastic#195456)
b904a17 
## Summary

I noticed that our `no-restricted-imports` rules were not working on
some parts of the codebase. Turns our the rule was overriden by mistake.
This PR fixes the rules and places that were not following them:

- lodash set for safety
- react-use for a bit smaller bundles
- router for context annoncement (`useExecutionContext`) and hopefully
easier upgrade to newer version

(cherry picked from commit 1055120)

# Conflicts:
#	.github/CODEOWNERS
@Dosant Dosant added the backport This PR is a backport of another PR label Oct 16, 2024
@Dosant Dosant enabled auto-merge (squash) October 16, 2024 10:14
@Dosant Dosant mentioned this pull request Oct 16, 2024
Merged
@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:actionable-obs Formerly "obs-ux-management", responsible for SLO, o11y alerting, significant events, & synthetics. labels Oct 16, 2024
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Oct 16, 2024

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@Dosant
Copy link
Copy Markdown
Contributor Author

Dosant commented Oct 16, 2024

@elasticmachine merge upstream

@Dosant
Copy link
Copy Markdown
Contributor Author

Dosant commented Oct 17, 2024

@elasticmachine merge upstream

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Oct 17, 2024 •
edited
Loading

💛 Build succeeded, but was flaky

  • Buildkite Build
  • Commit: 82dc6d4
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-196517-82dc6d4e5ae2

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
integrationAssistant 587 459 -128
securitySolution 6154 6040 -114
synthetics 1154 1032 -122
total -364

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
integrationAssistant 961.0KB 878.4KB -82.6KB
securitySolution 21.1MB 20.7MB -385.9KB
synthetics 1.2MB 1.1MB -79.2KB
total -547.7KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
integrationAssistant 10.3KB 10.4KB +116.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
securitySolution 548 551 +3
synthetics 52 53 +1
total +4

Total ESLint disabled count

id before after diff
securitySolution 634 637 +3
synthetics 58 59 +1
total +4

History

@Dosant Dosant merged commit 4770383 into elastic:8.x Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eokoneyo eokoneyo eokoneyo approved these changes

Assignees

No one assigned

Labels

backport This PR is a backport of another PR ci:project-deploy-observability Create an Observability project Team:actionable-obs Formerly "obs-ux-management", responsible for SLO, o11y alerting, significant events, & synthetics.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Dosant @elasticmachine @eokoneyo