remove Private from timefilter lib #19651
Conversation
💔 Build Failed |
|
jenkins, test this |
💚 Build Succeeded |
stacey-gammon
left a comment
stacey-gammon
left a comment
There was a problem hiding this comment.
LGTM. code review + pulled it down and played around with it. Visualizations updated with a change in time. Manually stepped through to investigate whether the logic change would have an impact and doesn't seem like it.
| return true; | ||
| } | ||
| } else { | ||
| return !_.isEqual(rangeA, rangeB); |
There was a problem hiding this comment.
This technically is different than the old code (I think anyway) because angular.equals doesn't care about variables on an object that start with $. But playing around with it, it doesn't seem to ever matter, so I think it's okay to change this. It actually seems pretty weird to ever fall in here anyway - only seems to be the case if either rangeA or rangeB are undefined.
spalger
left a comment
spalger
left a comment
There was a problem hiding this comment.
Code looks good, pulled it down and seems things are working great. Updating the time via the time picker, modifying the URL, dragging & clicking on a vis all work as expected. 👍
nreese
force-pushed
the
timefilter_phase1
branch
from
6fd47fe to
2739e0c
Compare
💔 Build Failed |
|
jenkins, test this |
💚 Build Succeeded |
4 participants
Part of moving Kibana's global timepicker to react will require migrating the timefilte from an angular service to a singleton. In order to avoid making a giant PR, this PR is just one phase in that migration. This PR removes
Privatefrom timefilter/lib and migrates mocha tests to jest.