[Cases] Adapt breadcrumbs to new stateful navigation#196494
Merged
semd merged 1 commit intoelastic:mainfrom Oct 16, 2024
Merged
[Cases] Adapt breadcrumbs to new stateful navigation#196494semd merged 1 commit intoelastic:mainfrom
semd merged 1 commit intoelastic:mainfrom
Conversation
semd
added
bug
Contributor
|
Pinging @elastic/response-ops (Team:ResponseOps) |
cnasikas
approved these changes
Oct 16, 2024
Contributor
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11363593914 |
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
cc @semd |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 16, 2024
## Summary Continuation of: elastic#196169 Adapted the Cases breadcrumbs to the new navigation for stateful (ESS) environments. Using the same `chrome.setBreadcrumbs` API, the case title breadcrumb now needs to be passed separately, inside the second _param_ object with `{ project: { value }}`. ### Screenshots Before <img width="776" alt="before" src="https://github.com/user-attachments/assets/29df8b36-71b3-4cf8-9c77-a72848ff91fc"> After <img width="776" alt="after" src="https://github.com/user-attachments/assets/bfa0bf06-9e94-454e-ace0-be63f13f9bc7"> (cherry picked from commit 7e310f0)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 16, 2024
…196519) # Backport This will backport the following commits from `main` to `8.x`: - [[Cases] Adapt breadcrumbs to new stateful navigation (#196494)](#196494) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Sergi Massaneda","email":"sergi.massaneda@elastic.co"},"sourceCommit":{"committedDate":"2024-10-16T10:14:46Z","message":"[Cases] Adapt breadcrumbs to new stateful navigation (#196494)\n\n## Summary\r\n\r\nContinuation of: https://github.com/elastic/kibana/pull/196169\r\n\r\nAdapted the Cases breadcrumbs to the new navigation for stateful (ESS)\r\nenvironments.\r\n\r\nUsing the same `chrome.setBreadcrumbs` API, the case title breadcrumb\r\nnow needs to be passed separately, inside the second _param_ object with\r\n`{ project: { value }}`.\r\n\r\n### Screenshots\r\n\r\nBefore\r\n<img width=\"776\" alt=\"before\"\r\nsrc=\"https://github.com/user-attachments/assets/29df8b36-71b3-4cf8-9c77-a72848ff91fc\">\r\n\r\n\r\nAfter\r\n<img width=\"776\" alt=\"after\"\r\nsrc=\"https://github.com/user-attachments/assets/bfa0bf06-9e94-454e-ace0-be63f13f9bc7\">","sha":"7e310f049baccadc46961746ba36d5c37687bd5e","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","backport","Team:ResponseOps","v9.0.0","backport:prev-minor","v8.16.0"],"title":"[Cases] Adapt breadcrumbs to new stateful navigation","number":196494,"url":"https://github.com/elastic/kibana/pull/196494","mergeCommit":{"message":"[Cases] Adapt breadcrumbs to new stateful navigation (#196494)\n\n## Summary\r\n\r\nContinuation of: https://github.com/elastic/kibana/pull/196169\r\n\r\nAdapted the Cases breadcrumbs to the new navigation for stateful (ESS)\r\nenvironments.\r\n\r\nUsing the same `chrome.setBreadcrumbs` API, the case title breadcrumb\r\nnow needs to be passed separately, inside the second _param_ object with\r\n`{ project: { value }}`.\r\n\r\n### Screenshots\r\n\r\nBefore\r\n<img width=\"776\" alt=\"before\"\r\nsrc=\"https://github.com/user-attachments/assets/29df8b36-71b3-4cf8-9c77-a72848ff91fc\">\r\n\r\n\r\nAfter\r\n<img width=\"776\" alt=\"after\"\r\nsrc=\"https://github.com/user-attachments/assets/bfa0bf06-9e94-454e-ace0-be63f13f9bc7\">","sha":"7e310f049baccadc46961746ba36d5c37687bd5e"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196494","number":196494,"mergeCommit":{"message":"[Cases] Adapt breadcrumbs to new stateful navigation (#196494)\n\n## Summary\r\n\r\nContinuation of: https://github.com/elastic/kibana/pull/196169\r\n\r\nAdapted the Cases breadcrumbs to the new navigation for stateful (ESS)\r\nenvironments.\r\n\r\nUsing the same `chrome.setBreadcrumbs` API, the case title breadcrumb\r\nnow needs to be passed separately, inside the second _param_ object with\r\n`{ project: { value }}`.\r\n\r\n### Screenshots\r\n\r\nBefore\r\n<img width=\"776\" alt=\"before\"\r\nsrc=\"https://github.com/user-attachments/assets/29df8b36-71b3-4cf8-9c77-a72848ff91fc\">\r\n\r\n\r\nAfter\r\n<img width=\"776\" alt=\"after\"\r\nsrc=\"https://github.com/user-attachments/assets/bfa0bf06-9e94-454e-ace0-be63f13f9bc7\">","sha":"7e310f049baccadc46961746ba36d5c37687bd5e"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Sergi Massaneda <sergi.massaneda@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Continuation of: #196169
Adapted the Cases breadcrumbs to the new navigation for stateful (ESS) environments.
Using the same
chrome.setBreadcrumbsAPI, the case title breadcrumb now needs to be passed separately, inside the second param object with{ project: { value }}.Screenshots
Before
After
