-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[DOCS] 6.3 Release Notes #19636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] 6.3 Release Notes #19636
Conversation
💚 Build Succeeded |
rayafratkina
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
epixa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM though I have some notes:
Overall, I have a lot of the same feedback for this PR as I have for #19634, like consistent new lines at 80 chars, not repeating titles, sentence casing. If you do make these sorts of changes in that PR, then I recommend doing them here as well.
Also, while it isn't introduced in this PR, I reiterate a comment I made in the other PR about not including commented out sections in this changelog. They just make this file harder to parse, and things that are commented tended to become neglected/lack review. For example, one of the commented out sections in this changelog is "Breaking Java Changes", which is clearly not even a Kibana thing, but it was probably copied and pasted over and no one noticed it because it was commented out.
Unrelated, in the future we should probably submit release notes and highlights in the same PR because as it stands now, neither of these two PRs builds properly without the other one due to the cross-linking. Kibana CI doesn't build docs right now, but we intend for it to build docs in the future, and this would cause a red build.
💚 Build Succeeded |
💚 Build Succeeded |
💚 Build Succeeded |
* [DOCS] 6.3 Release Notes * [DOCS] Incorporated review comments * [DOC] Updated note about regression because it also affects pipeline creation * [DOCS] Minor updates to release notes
|
@gchaps: Hi, thanks for working on release notes (I used to do that in a past life). I was wondering if I could encourage you to use a spell checker to improve their quality/readability. I'm asking because the tool I'm using flagged (at least): -- I made the mistake of running my tool on the 6.3 branch, and since I'm moving my commits to master, I'm dropping this delta. |
This PR is for the 6.3 Release Notes.
My editor automatically removed some spaces in the 6.2.4 Release notes and lower so you can ignore those changes.