Skip to content

[8.x] [Stateful sidenav] Welcome tour (#194926)#196298

Merged
sebelga merged 1 commit intoelastic:8.xfrom
sebelga:backport/8.x/pr-194926
Oct 15, 2024
Merged

[8.x] [Stateful sidenav] Welcome tour (#194926)#196298
sebelga merged 1 commit intoelastic:8.xfrom
sebelga:backport/8.x/pr-194926

Conversation

@sebelga
Copy link
Copy Markdown
Contributor

@sebelga sebelga commented Oct 15, 2024

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

(cherry picked from commit 8cceaee)

# Conflicts:
#	x-pack/plugins/spaces/common/constants.ts
@sebelga sebelga added the backport This PR is a backport of another PR label Oct 15, 2024
@sebelga sebelga enabled auto-merge (squash) October 15, 2024 12:35
@sebelga sebelga requested a review from azasypkin October 15, 2024 12:36
@sebelga sebelga merged commit db2adf7 into elastic:8.x Oct 15, 2024
@elasticmachine
Copy link
Copy Markdown
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
spaces 335 338 +3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
spaces 255.0KB 255.6KB +581.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
spaces 30.8KB 33.2KB +2.3KB

@sebelga sebelga deleted the backport/8.x/pr-194926 branch October 15, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants