[package.json] Add missing dev dependencies #19625
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbudz
added
review
Team:Core
Contributor
💔 Build Failed |
jbudz
force-pushed
the
package-dev-dependencies
branch
2 times, most recently
from
7777511 to
d664aec
Compare
tylersmalley
approved these changes
Jun 7, 2018
Contributor
💔 Build Failed |
Member
Author
|
test it please |
Member
Author
|
test this please |
jbudz
force-pushed
the
package-dev-dependencies
branch
from
d664aec to
d18f90a
Compare
Contributor
💔 Build Failed |
Member
Author
|
retest |
Contributor
💚 Build Succeeded |
jbudz
added a commit
that referenced
this pull request
Jun 8, 2018
maryia-lapata
pushed a commit
to maryia-lapata/kibana
that referenced
this pull request
Jun 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
zlibanddelto our top level dev dependencies, both are used in src/dev. They're both sub dependencies currently, and it's unlikely they'll accidentally go missing convention is to add them to our package json.