[ObsUX][APM-Otel] Fix index pattern to accept otel indices, bump up version#196164
Merged
MiriamAparicio merged 2 commits intoelastic:mainfrom Oct 14, 2024
Merged
Conversation
MiriamAparicio
added
release_note:skip
Contributor
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
jennypavlova
approved these changes
Oct 14, 2024
Member
jennypavlova
left a comment
jennypavlova
left a comment
There was a problem hiding this comment.
Thanks for the fix! ❤️ I added a question but it should be fine as is, I think (I haven't tested it). Have you tested this against the e2e PoC?
x-pack/plugins/entity_manager/server/lib/entities/built_in/services_from_ecs_data.ts
Show resolved
Hide resolved
rmyz
approved these changes
Oct 14, 2024
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
|
klacabane
approved these changes
Oct 14, 2024
| id: `${BUILT_IN_ID_PREFIX}services_from_ecs_data`, | ||
| name: 'Services from ECS data', | ||
| description: | ||
| 'This definition extracts service entities from common data streams by looking for the ECS field service.name', |
Contributor
There was a problem hiding this comment.
Should we mention that otel services will also be extracted from traces?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #195653
The problem
The current service definition used by the transforms uses the
traces-apm*indices and service.name as identifier fields, otel hastraces-*.otel-*Solution
Modify the definition of the index patterns to look for
traces*We can see now otel service in the entities inventory