[FTR] update svl search config and custom role test#196126
Merged
dmlemeshko merged 3 commits intoelastic:mainfrom Oct 14, 2024
Merged
[FTR] update svl search config and custom role test#196126dmlemeshko merged 3 commits intoelastic:mainfrom
dmlemeshko merged 3 commits intoelastic:mainfrom
Conversation
dmlemeshko
added
release_note:skip
dmlemeshko
commented
Oct 14, 2024
Comment on lines
22
to
27
| `--xpack.cloud.id=ES3_FTR_TESTS:ZmFrZS1kb21haW4uY2xkLmVsc3RjLmNvJGZha2Vwcm9qZWN0aWQuZXMkZmFrZXByb2plY3RpZC5rYg==`, | ||
| `--xpack.cloud.serverless.project_id=fakeprojectid`, | ||
| `--xpack.cloud.serverless.project_name=ES3_FTR_TESTS`, | ||
| `--xpack.cloud.serverless.project_type=elasticsearch`, | ||
| `--xpack.cloud.base_url=https://fake-cloud.elastic.co`, | ||
| `--xpack.cloud.profile_url=/user/settings/`, | ||
| `--xpack.cloud.billing_url=/billing/overview/`, |
Contributor
Author
There was a problem hiding this comment.
@pheyos we probably need to move these arguments to shared config as it is relevant for all projects. But I'm not sure if we want to generate id/name of have a static value based on project type.
dmlemeshko
commented
Oct 14, 2024
Comment on lines
+65
to
+66
| // Playground should be also hidden, probably a bug | ||
| // await testSubjects.missingOrFail('~nav-item-id-searchPlayground'); |
Contributor
Author
There was a problem hiding this comment.
@elastic/search-kibana
It seems like application privileges are not properly applied to searchPlayground. The role I defined has only access to Discover, but I still see and able to open Playground link, later to see error message
Similar question is if Connectors should be visible by default?
Role descriptors:
{
elasticsearch: {
indices: [{ names: ['logstash-*'], privileges: ['read', 'view_index_metadata'] }],
},
kibana: [
{
feature: {
discover: ['read'],
},
spaces: ['*'],
},
],
}
Contributor
There was a problem hiding this comment.
Yes, this is known and something that is being worked on currently
Contributor
💚 Build Succeeded
Metrics [docs]
cc @dmlemeshko |
TattdCodeMonkey
approved these changes
Oct 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes
xpack.cloud.serverless.project_typefrom FTR config, the value breaks mockIdpPlugin that expects it to be defined assearch. We will address project type unification separately.Closes #195976