Skip to content

[SecuritySolution] Set correct onboarding cards capabilities#195990

Merged
semd merged 90 commits intoelastic:mainfrom
semd:183765_fix_onboarding_capabilities
Oct 14, 2024
Merged

[SecuritySolution] Set correct onboarding cards capabilities#195990
semd merged 90 commits intoelastic:mainfrom
semd:183765_fix_onboarding_capabilities

Conversation

@semd
Copy link
Copy Markdown
Contributor

@semd semd commented Oct 11, 2024

Summary

Sets the correct capabilities for Onboarding cards:

  • Integrations:

    • capability: fleet.read: The only privilege a user needs to access the Integrations page, it won't be able to install anything though. (fleet is the id for "Integrations" capability, the one for "Fleet" is fleetv2).
  • Dashboards:

    • capability: dashboard.show
  • AI Assisant:

    • capability: securitySolutionAssistant.ai-assistant,
    • license: enterprise
  • Attack Discovery (still hidden):

    • capability: securitySolutionAttackDiscovery.attack-discovery,
    • license: enterprise

semd and others added 30 commits September 6, 2024 12:38
…_hub_new_architecture' into refactor/onboarding_hub_new_architecture
@semd semd added release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore v8.16.0 labels Oct 11, 2024
@semd semd self-assigned this Oct 11, 2024
@semd semd marked this pull request as ready for review October 14, 2024 07:41
@semd semd requested a review from a team as a code owner October 14, 2024 07:41
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/security-threat-hunting-explore (Team:Threat Hunting:Explore)

Copy link
Copy Markdown
Contributor

@agusruidiazgd agusruidiazgd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@semd
Copy link
Copy Markdown
Contributor Author

semd commented Oct 14, 2024

@elasticmachine merge upstream

@semd semd enabled auto-merge (squash) October 14, 2024 08:13
@semd semd disabled auto-merge October 14, 2024 09:30
@semd semd merged commit f90dc39 into elastic:main Oct 14, 2024
@kibanamachine
Copy link
Copy Markdown
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11325420840

kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Oct 14, 2024
…#195990)

## Summary

Sets the correct capabilities for Onboarding cards:

- Integrations:
- capability: `fleet.read`: The only privilege a user needs to access
the Integrations page, it won't be able to install anything though.
(`fleet` is the id for "Integrations" capability, the one for "Fleet" is
`fleetv2`).

- Dashboards:
  - capability: `dashboard.show`

- AI Assisant:
  - capability: `securitySolutionAssistant.ai-assistant`,
  - license: `enterprise`

- Attack Discovery (still hidden):
  - capability: `securitySolutionAttackDiscovery.attack-discovery`,
  - license: `enterprise`

---------

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Angela Chuang <yi-chun.chuang@elastic.co>
Co-authored-by: Agustina Nahir Ruidiaz <agustina.ruidiaz@elastic.co>
(cherry picked from commit f90dc39)
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 14, 2024
…195990) (#196082)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[SecuritySolution] Set correct onboarding cards capabilities
(#195990)](#195990)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Sergi
Massaneda","email":"sergi.massaneda@elastic.co"},"sourceCommit":{"committedDate":"2024-10-14T10:10:46Z","message":"[SecuritySolution]
Set correct onboarding cards capabilities (#195990)\n\n##
Summary\r\n\r\nSets the correct capabilities for Onboarding
cards:\r\n\r\n- Integrations: \r\n- capability: `fleet.read`: The only
privilege a user needs to access\r\nthe Integrations page, it won't be
able to install anything though.\r\n(`fleet` is the id for
\"Integrations\" capability, the one for \"Fleet\"
is\r\n`fleetv2`).\r\n\r\n- Dashboards: \r\n - capability:
`dashboard.show`\r\n\r\n- AI Assisant: \r\n - capability:
`securitySolutionAssistant.ai-assistant`, \r\n - license:
`enterprise`\r\n\r\n- Attack Discovery (still hidden): \r\n -
capability: `securitySolutionAttackDiscovery.attack-discovery`, \r\n -
license: `enterprise`\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic
Machine <elasticmachine@users.noreply.github.com>\r\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by:
Angela Chuang <yi-chun.chuang@elastic.co>\r\nCo-authored-by: Agustina
Nahir Ruidiaz
<agustina.ruidiaz@elastic.co>","sha":"f90dc39f7e8547467c53ffc7f74ada07a06be040","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:
SecuritySolution","Team:Threat
Hunting:Explore","backport:prev-minor","v8.16.0"],"title":"[SecuritySolution]
Set correct onboarding cards
capabilities","number":195990,"url":"https://github.com/elastic/kibana/pull/195990","mergeCommit":{"message":"[SecuritySolution]
Set correct onboarding cards capabilities (#195990)\n\n##
Summary\r\n\r\nSets the correct capabilities for Onboarding
cards:\r\n\r\n- Integrations: \r\n- capability: `fleet.read`: The only
privilege a user needs to access\r\nthe Integrations page, it won't be
able to install anything though.\r\n(`fleet` is the id for
\"Integrations\" capability, the one for \"Fleet\"
is\r\n`fleetv2`).\r\n\r\n- Dashboards: \r\n - capability:
`dashboard.show`\r\n\r\n- AI Assisant: \r\n - capability:
`securitySolutionAssistant.ai-assistant`, \r\n - license:
`enterprise`\r\n\r\n- Attack Discovery (still hidden): \r\n -
capability: `securitySolutionAttackDiscovery.attack-discovery`, \r\n -
license: `enterprise`\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic
Machine <elasticmachine@users.noreply.github.com>\r\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by:
Angela Chuang <yi-chun.chuang@elastic.co>\r\nCo-authored-by: Agustina
Nahir Ruidiaz
<agustina.ruidiaz@elastic.co>","sha":"f90dc39f7e8547467c53ffc7f74ada07a06be040"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195990","number":195990,"mergeCommit":{"message":"[SecuritySolution]
Set correct onboarding cards capabilities (#195990)\n\n##
Summary\r\n\r\nSets the correct capabilities for Onboarding
cards:\r\n\r\n- Integrations: \r\n- capability: `fleet.read`: The only
privilege a user needs to access\r\nthe Integrations page, it won't be
able to install anything though.\r\n(`fleet` is the id for
\"Integrations\" capability, the one for \"Fleet\"
is\r\n`fleetv2`).\r\n\r\n- Dashboards: \r\n - capability:
`dashboard.show`\r\n\r\n- AI Assisant: \r\n - capability:
`securitySolutionAssistant.ai-assistant`, \r\n - license:
`enterprise`\r\n\r\n- Attack Discovery (still hidden): \r\n -
capability: `securitySolutionAttackDiscovery.attack-discovery`, \r\n -
license: `enterprise`\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic
Machine <elasticmachine@users.noreply.github.com>\r\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by:
Angela Chuang <yi-chun.chuang@elastic.co>\r\nCo-authored-by: Agustina
Nahir Ruidiaz
<agustina.ruidiaz@elastic.co>","sha":"f90dc39f7e8547467c53ffc7f74ada07a06be040"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Sergi Massaneda <sergi.massaneda@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.16.0 v9.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants