Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Skip recently added tests for updating restricted fields in prebuilt rules #195926

Merged
merged 1 commit into from
Oct 11, 2024
Merged

[Security Solution] Skip recently added tests for updating restricted fields in prebuilt rules #195926

merged 1 commit into from
Oct 11, 2024

Conversation

banderror
Copy link
Contributor

@banderror banderror commented Oct 11, 2024 •
edited
Loading

Summary

The new tests added yesterday in #195318 have failed in the periodic pipeline (build).

Skipping for now in MKI pipelines (periodic pipeline and the 2nd quality gate), otherwise it will block the next Serverless release.

Ticket for unskipping: #195921

@banderror banderror added failed-test A test failure on a tracked branch, potentially flaky-test skipped-test release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Rule Management Security Detection Rule Management Team Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules labels Oct 11, 2024
@banderror banderror self-assigned this Oct 11, 2024
@banderror banderror requested a review from a team as a code owner October 11, 2024 13:54
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detection-rule-management (Team:Detection Rule Management)

@banderror banderror mentioned this pull request Oct 11, 2024
Open
maximpn
maximpn approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@maximpn maximpn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@banderror banderror enabled auto-merge (squash) October 11, 2024 14:26
@banderror banderror merged commit d57bc9a into elastic:main Oct 11, 2024
37 checks passed
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

cc @banderror

@banderror banderror deleted the skip-new-rule-update-tests branch October 11, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximpn maximpn maximpn approved these changes

@jpdjere jpdjere Awaiting requested review from jpdjere

@dplumlee dplumlee Awaiting requested review from dplumlee

Assignees

@banderror banderror

Labels
backport:skip This commit does not require backporting failed-test A test failure on a tracked branch, potentially flaky-test Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules release_note:skip Skip the PR/issue when compiling release notes skipped-test Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@banderror @elasticmachine @maximpn @kibanamachine