[ES|QL] Updates the validation tests#195847
Merged
stratoula merged 5 commits intoelastic:mainfrom Oct 14, 2024
Merged
Conversation
Contributor
Author
|
/ci |
stratoula
added
release_note:skip
Contributor
|
Pinging @elastic/kibana-esql (Team:ESQL) |
Contributor
|
Looking good but I think it would be nice if @vadimkibana reviewed. Vadim, didn't you set up this separation between the test suite ( In this case, we don't want to check these tests against Elasticsearch. Given that, do we need this separation? |
drewdaemon
reviewed
Oct 14, 2024
Contributor
There was a problem hiding this comment.
probably don't need command in the name here
Contributor
Author
There was a problem hiding this comment.
yeah, I removed it!
Contributor
Author
|
/ci |
drewdaemon
approved these changes
Oct 14, 2024
Contributor
drewdaemon
left a comment
drewdaemon
left a comment
There was a problem hiding this comment.
Nice work! Synced with Vadim and I understand things now.
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest FailuresMetrics [docs]
History
|
Contributor
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11331722212 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 14, 2024
## Summary Moves the CCS tests to its own file ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 36cf5ab)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 14, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [[ES|QL] Updates the validation tests (#195847)](#195847) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Stratoula Kalafateli","email":"efstratia.kalafateli@elastic.co"},"sourceCommit":{"committedDate":"2024-10-14T16:44:40Z","message":"[ES|QL] Updates the validation tests (#195847)\n\n## Summary\r\n\r\nMoves the CCS tests to its own file\r\n\r\n### Checklist\r\n\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"36cf5ab5bb4d6512b06fa9b2b7e7f4383c223b3a","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","Feature:ES|QL","Team:ESQL","v8.16.0"],"title":"[ES|QL] Updates the validation tests","number":195847,"url":"https://github.com/elastic/kibana/pull/195847","mergeCommit":{"message":"[ES|QL] Updates the validation tests (#195847)\n\n## Summary\r\n\r\nMoves the CCS tests to its own file\r\n\r\n### Checklist\r\n\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"36cf5ab5bb4d6512b06fa9b2b7e7f4383c223b3a"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195847","number":195847,"mergeCommit":{"message":"[ES|QL] Updates the validation tests (#195847)\n\n## Summary\r\n\r\nMoves the CCS tests to its own file\r\n\r\n### Checklist\r\n\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"36cf5ab5bb4d6512b06fa9b2b7e7f4383c223b3a"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves the CCS tests to its own file
Checklist