Flipped Security Entity Store flag to being a "disable" flag#195818
Merged
jaredburgettelastic merged 9 commits intoelastic:mainfrom Oct 15, 2024
Merged
Conversation
… the feature is enabled by default. Also disabled in Serverless.
jaredburgettelastic
added
backport:prev-minor
release_note:skip
jaredburgettelastic
changed the title
…s it is disabled there
jloleysens
approved these changes
Oct 11, 2024
pmuellr
approved these changes
Oct 14, 2024
Contributor
pmuellr
left a comment
pmuellr
left a comment
There was a problem hiding this comment.
ResponseOps changes LGTM
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
History
|
Contributor
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11339535953 |
Contributor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
hop-dev
pushed a commit
to hop-dev/kibana
that referenced
this pull request
Oct 15, 2024
…#195818) ## Summary The Security Solution Entity Store feature will now be available by default. However, there will be a flag that can be switched on, if desired, to **disable** that feature entirely. Regardless of whether this flag is enabled or not, Security's Entity Store is still only fully enabled through an enablement workflow. In other words, a Security Solution customer must turn on the feature through an onboarding workflow in order to enable its features. Additionally, we are disabling this feature in Serverless at first, to perform proper Serverless load/performance testing. (We do not expect it to be significantly different than ESS/ECH, but are doing so out of an abundance of caution). --------- Co-authored-by: Pablo Machado <pablo.nevesmachado@elastic.co> (cherry picked from commit ea582dc) # Conflicts: # config/serverless.security.yml # x-pack/test/security_solution_api_integration/test_suites/entity_analytics/entity_store/trial_license_complete_tier/engine.ts
This was referenced Oct 15, 2024
hop-dev
added a commit
that referenced
this pull request
Oct 15, 2024
…195818) (#196261) # Backport This will backport the following commits from `main` to `8.x`: - [Flipped Security Entity Store flag to being a "disable" flag (#195818)](#195818) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Jared Burgett","email":"147995946+jaredburgettelastic@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-10-15T04:56:08Z","message":"Flipped Security Entity Store flag to being a \"disable\" flag (#195818)\n\n## Summary\r\n\r\nThe Security Solution Entity Store feature will now be available by\r\ndefault. However, there will be a flag that can be switched on, if\r\ndesired, to **disable** that feature entirely.\r\n\r\nRegardless of whether this flag is enabled or not, Security's Entity\r\nStore is still only fully enabled through an enablement workflow. In\r\nother words, a Security Solution customer must turn on the feature\r\nthrough an onboarding workflow in order to enable its features.\r\n\r\nAdditionally, we are disabling this feature in Serverless at first, to\r\nperform proper Serverless load/performance testing. (We do not expect it\r\nto be significantly different than ESS/ECH, but are doing so out of an\r\nabundance of caution).\r\n\r\n---------\r\n\r\nCo-authored-by: Pablo Machado <pablo.nevesmachado@elastic.co>","sha":"ea582dc65029f5537d6093c3fadb8b90b7768f91","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor"],"number":195818,"url":"https://github.com/elastic/kibana/pull/195818","mergeCommit":{"message":"Flipped Security Entity Store flag to being a \"disable\" flag (#195818)\n\n## Summary\r\n\r\nThe Security Solution Entity Store feature will now be available by\r\ndefault. However, there will be a flag that can be switched on, if\r\ndesired, to **disable** that feature entirely.\r\n\r\nRegardless of whether this flag is enabled or not, Security's Entity\r\nStore is still only fully enabled through an enablement workflow. In\r\nother words, a Security Solution customer must turn on the feature\r\nthrough an onboarding workflow in order to enable its features.\r\n\r\nAdditionally, we are disabling this feature in Serverless at first, to\r\nperform proper Serverless load/performance testing. (We do not expect it\r\nto be significantly different than ESS/ECH, but are doing so out of an\r\nabundance of caution).\r\n\r\n---------\r\n\r\nCo-authored-by: Pablo Machado <pablo.nevesmachado@elastic.co>","sha":"ea582dc65029f5537d6093c3fadb8b90b7768f91"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195818","number":195818,"mergeCommit":{"message":"Flipped Security Entity Store flag to being a \"disable\" flag (#195818)\n\n## Summary\r\n\r\nThe Security Solution Entity Store feature will now be available by\r\ndefault. However, there will be a flag that can be switched on, if\r\ndesired, to **disable** that feature entirely.\r\n\r\nRegardless of whether this flag is enabled or not, Security's Entity\r\nStore is still only fully enabled through an enablement workflow. In\r\nother words, a Security Solution customer must turn on the feature\r\nthrough an onboarding workflow in order to enable its features.\r\n\r\nAdditionally, we are disabling this feature in Serverless at first, to\r\nperform proper Serverless load/performance testing. (We do not expect it\r\nto be significantly different than ESS/ECH, but are doing so out of an\r\nabundance of caution).\r\n\r\n---------\r\n\r\nCo-authored-by: Pablo Machado <pablo.nevesmachado@elastic.co>","sha":"ea582dc65029f5537d6093c3fadb8b90b7768f91"}}]}] BACKPORT--> Co-authored-by: Jared Burgett <147995946+jaredburgettelastic@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Security Solution Entity Store feature will now be available by default. However, there will be a flag that can be switched on, if desired, to disable that feature entirely.
Regardless of whether this flag is enabled or not, Security's Entity Store is still only fully enabled through an enablement workflow. In other words, a Security Solution customer must turn on the feature through an onboarding workflow in order to enable its features.
Additionally, we are disabling this feature in Serverless at first, to perform proper Serverless load/performance testing. (We do not expect it to be significantly different than ESS/ECH, but are doing so out of an abundance of caution).