fix: [Stateful: Home page] Not checked radio button receive focus a first element in radio group.#195745
Merged
alexwizp merged 4 commits intoelastic:mainfrom Oct 15, 2024
Merged
fix: [Stateful: Home page] Not checked radio button receive focus a first element in radio group.#195745alexwizp merged 4 commits intoelastic:mainfrom
alexwizp merged 4 commits intoelastic:mainfrom
Conversation
…first element in radio group. Closes: elastic#195190
alexwizp
added
Project:Accessibility
release_note:skip
Contributor
|
Pinging @elastic/kibana-accessibility (Project:Accessibility) |
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest FailuresMetrics [docs]Async chunks
History
|
Contributor
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11344279891 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 15, 2024
…irst element in radio group. (elastic#195745) Closes: elastic#195190 ## Description According to ARIA Authoring Practices Guide, focus should be on the checked radio button when the user reaches radio group while navigating using only keyboard. As of now, because all the time first radio button in the group receives focus, even if it is not checked, it may cause confusion and could potentially lead users to unintentionally change their selection without checking all checkboxes which exist in the group. ## What was changed: 1. Added name attribute for `EuiRadioGroup`. ## Screen: https://github.com/user-attachments/assets/20db2394-b9db-4c40-9e72-53ee860cd066 (cherry picked from commit 2c1d5ce)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 15, 2024
…us a first element in radio group. (#195745) (#196273) # Backport This will backport the following commits from `main` to `8.x`: - [fix: [Stateful: Home page] Not checked radio button receive focus a first element in radio group. (#195745)](#195745) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Alexey Antonov","email":"alexwizp@gmail.com"},"sourceCommit":{"committedDate":"2024-10-15T10:33:30Z","message":"fix: [Stateful: Home page] Not checked radio button receive focus a first element in radio group. (#195745)\n\nCloses: #195190\r\n\r\n## Description \r\n\r\nAccording to ARIA Authoring Practices Guide, focus should be on the\r\nchecked radio button when the user reaches radio group while navigating\r\nusing only keyboard. As of now, because all the time first radio button\r\nin the group receives focus, even if it is not checked, it may cause\r\nconfusion and could potentially lead users to unintentionally change\r\ntheir selection without checking all checkboxes which exist in the\r\ngroup.\r\n\r\n## What was changed: \r\n1. Added name attribute for `EuiRadioGroup`. \r\n\r\n## Screen: \r\n\r\n\r\nhttps://github.com/user-attachments/assets/20db2394-b9db-4c40-9e72-53ee860cd066","sha":"2c1d5ce08fa55275148e61012aa49061f01c3dd9","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Project:Accessibility","release_note:skip","v9.0.0","Team:Search","backport:prev-minor"],"title":"fix: [Stateful: Home page] Not checked radio button receive focus a first element in radio group.","number":195745,"url":"https://github.com/elastic/kibana/pull/195745","mergeCommit":{"message":"fix: [Stateful: Home page] Not checked radio button receive focus a first element in radio group. (#195745)\n\nCloses: #195190\r\n\r\n## Description \r\n\r\nAccording to ARIA Authoring Practices Guide, focus should be on the\r\nchecked radio button when the user reaches radio group while navigating\r\nusing only keyboard. As of now, because all the time first radio button\r\nin the group receives focus, even if it is not checked, it may cause\r\nconfusion and could potentially lead users to unintentionally change\r\ntheir selection without checking all checkboxes which exist in the\r\ngroup.\r\n\r\n## What was changed: \r\n1. Added name attribute for `EuiRadioGroup`. \r\n\r\n## Screen: \r\n\r\n\r\nhttps://github.com/user-attachments/assets/20db2394-b9db-4c40-9e72-53ee860cd066","sha":"2c1d5ce08fa55275148e61012aa49061f01c3dd9"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195745","number":195745,"mergeCommit":{"message":"fix: [Stateful: Home page] Not checked radio button receive focus a first element in radio group. (#195745)\n\nCloses: #195190\r\n\r\n## Description \r\n\r\nAccording to ARIA Authoring Practices Guide, focus should be on the\r\nchecked radio button when the user reaches radio group while navigating\r\nusing only keyboard. As of now, because all the time first radio button\r\nin the group receives focus, even if it is not checked, it may cause\r\nconfusion and could potentially lead users to unintentionally change\r\ntheir selection without checking all checkboxes which exist in the\r\ngroup.\r\n\r\n## What was changed: \r\n1. Added name attribute for `EuiRadioGroup`. \r\n\r\n## Screen: \r\n\r\n\r\nhttps://github.com/user-attachments/assets/20db2394-b9db-4c40-9e72-53ee860cd066","sha":"2c1d5ce08fa55275148e61012aa49061f01c3dd9"}}]}] BACKPORT--> Co-authored-by: Alexey Antonov <alexwizp@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #195190
Description
According to ARIA Authoring Practices Guide, focus should be on the checked radio button when the user reaches radio group while navigating using only keyboard. As of now, because all the time first radio button in the group receives focus, even if it is not checked, it may cause confusion and could potentially lead users to unintentionally change their selection without checking all checkboxes which exist in the group.
What was changed:
EuiRadioGroup.Screen:
Screen.Recording.2024-10-10.at.14.10.30.mov