Skip to content

[Security Assistant] Knowledge base conflict fix#195659

Merged
Ikuni17 merged 1 commit intoelastic:mainfrom
stephmilovic:fix_conflict_kb
Oct 9, 2024
Merged

[Security Assistant] Knowledge base conflict fix#195659
Ikuni17 merged 1 commit intoelastic:mainfrom
stephmilovic:fix_conflict_kb

Conversation

@stephmilovic
Copy link
Copy Markdown
Contributor

@stephmilovic stephmilovic commented Oct 9, 2024

@stephmilovic stephmilovic added release_note:skip Skip the PR/issue when compiling release notes v9.0.0 backport:prev-minor Team:Security Generative AI Security Generative AI v8.16.0 labels Oct 9, 2024
@stephmilovic stephmilovic requested a review from a team as a code owner October 9, 2024 17:33
@Ikuni17 Ikuni17 merged commit 1bf3f2a into elastic:main Oct 9, 2024
@kibanamachine
Copy link
Copy Markdown
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11260140711

@kibanamachine
Copy link
Copy Markdown
Contributor

💔 All backports failed

Status Branch Result
8.x Backport failed because of merge conflicts

You might need to backport the following PRs to 8.x:
- [Security Assistant] V2 Knowledge Base Settings feedback and fixes (#194354)
- [Security GenAI] Remove assistantNaturalLanguageESQLTool feature flag and enable by default (#195480)

Manual backport

To create the backport manually run:

node scripts/backport --pr 195659

Questions ?

Please refer to the Backport tool documentation

@elasticmachine
Copy link
Copy Markdown
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #75 / Machine Learning anomaly detectors POST anomaly_detectors _forecast with spaces should delete forecast for user with permissions

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 20.6MB 20.6MB +177.0B

@stephmilovic
Copy link
Copy Markdown
Contributor Author

FYI I did not backport this because I had to bring the changes from the commit over to a different PR against 8.x in order to avoid problems: e66e06d

So backporting is unnecessary as the code already exists in 8.x

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 11, 2024
@kibanamachine
Copy link
Copy Markdown
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 195659 locally

@stephmilovic stephmilovic added the backport:skip This PR does not require backporting label Oct 11, 2024
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Security Generative AI Security Generative AI v8.16.0 v9.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants