Skip to content

[8.x] [Lens][ES|QL] Do not refetch the attributes if the query hasn't changed (#195196)#195649

Merged
kibanamachine merged 1 commit intoelastic:8.xfrom
kibanamachine:backport/8.x/pr-195196
Oct 9, 2024
Merged

[8.x] [Lens][ES|QL] Do not refetch the attributes if the query hasn't changed (#195196)#195649
kibanamachine merged 1 commit intoelastic:8.xfrom
kibanamachine:backport/8.x/pr-195196

Conversation

@kibanamachine
Copy link
Copy Markdown
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

…ed (elastic#195196)

## Summary

When a user is creating a Lens ES|QL chart we run the suggestions api
even if the query hasn't changed. This PR adds a guard to avoid
refetching the attributes when the query hasn't changed at all.

(cherry picked from commit a209fe8)
@kibanamachine kibanamachine merged commit 4884d43 into elastic:8.x Oct 9, 2024
@elasticmachine
Copy link
Copy Markdown
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #67 / core route timeouts idle socket should timeout if payload sending has too long of an idle period
  • [job] [logs] FTR Configs #71 / ObservabilityApp o11y sidenav sidenav & breadcrumbs renders the correct nav and navigate to links

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.5MB 1.5MB +34.0B

cc @stratoula

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants