Skip to content

[Inventory] Fixing entity links#195625

Merged
cauemarcondes merged 2 commits intoelastic:mainfrom
cauemarcondes:inventory-link-issue
Oct 9, 2024
Merged

[Inventory] Fixing entity links#195625
cauemarcondes merged 2 commits intoelastic:mainfrom
cauemarcondes:inventory-link-issue

Conversation

@cauemarcondes
Copy link
Copy Markdown
Contributor

@cauemarcondes cauemarcondes commented Oct 9, 2024 •
edited by kibanamachine
Loading

Regression from #195204

@cauemarcondes cauemarcondes requested a review from a team October 9, 2024 15:03
@botelastic botelastic Bot added the ci:project-deploy-observability Create an Observability project label Oct 9, 2024
@cauemarcondes cauemarcondes added release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor v8.16.0 and removed ci:project-deploy-observability Create an Observability project labels Oct 9, 2024
@botelastic botelastic Bot added the ci:project-deploy-observability Create an Observability project label Oct 9, 2024
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Oct 9, 2024 •
edited
Loading

💛 Build succeeded, but was flaky

  • Buildkite Build
  • Commit: 789bb61
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-195625-789bb61061af

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #22 / cases security and spaces enabled: basic Common migrations migrations 7.11.1 -> latest stack version "before all" hook for "adds rule info to only alert comments for 7.12"
  • [job] [logs] FTR Configs #55 / Machine Learning anomaly detectors POST anomaly_detectors _forecast with spaces should delete forecast for user with permissions

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
inventory 222.7KB 222.8KB +113.0B

History

@cauemarcondes cauemarcondes merged commit d2644ff into elastic:main Oct 9, 2024
@cauemarcondes cauemarcondes deleted the inventory-link-issue branch October 9, 2024 18:19
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Oct 9, 2024

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11260770702

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 9, 2024
@cauemarcondes
[Inventory] Fixing entity links (elastic#195625)
4575367 
Regression from elastic#195204

(cherry picked from commit d2644ff)
@kibanamachine kibanamachine mentioned this pull request Oct 9, 2024
Merged
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Oct 9, 2024

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 9, 2024
@kibanamachine @cauemarcondes
[8.x] [Inventory] Fixing entity links (#195625) (#195667)
a3da125 
# Backport

This will backport the following commits from `main` to `8.x`:
- [[Inventory] Fixing entity links
(#195625)](#195625)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Cauê
Marcondes","email":"55978943+cauemarcondes@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-10-09T18:19:49Z","message":"[Inventory]
Fixing entity links (#195625)\n\nRegression from
https://github.com/elastic/kibana/pull/195204","sha":"d2644ffe49ea732e5f048957a51350efbc321687","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","v8.16.0"],"title":"[Inventory]
Fixing entity
links","number":195625,"url":"https://github.com/elastic/kibana/pull/195625","mergeCommit":{"message":"[Inventory]
Fixing entity links (#195625)\n\nRegression from
https://github.com/elastic/kibana/pull/195204","sha":"d2644ffe49ea732e5f048957a51350efbc321687"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195625","number":195625,"mergeCommit":{"message":"[Inventory]
Fixing entity links (#195625)\n\nRegression from
https://github.com/elastic/kibana/pull/195204","sha":"d2644ffe49ea732e5f048957a51350efbc321687"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Cauê Marcondes <55978943+cauemarcondes@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iblancof iblancof iblancof approved these changes

Assignees

No one assigned

Labels

ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes v8.16.0 v9.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cauemarcondes @elasticmachine @kibanamachine @iblancof