[dashboard] do not async import dashboard actions on plugin load#195616
Merged
nreese merged 1 commit intoelastic:mainfrom Oct 9, 2024
Merged
[dashboard] do not async import dashboard actions on plugin load#195616nreese merged 1 commit intoelastic:mainfrom
nreese merged 1 commit intoelastic:mainfrom
Conversation
Contributor
Author
|
/ci |
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
|
nreese
added
Team:Presentation
Contributor
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
Heenawter
approved these changes
Oct 9, 2024
Contributor
Heenawter
left a comment
Heenawter
left a comment
There was a problem hiding this comment.
This is something we've been meaning to do for awhile, so changes are straight forward. Thanks for tackling this - LGTM 👍
Contributor
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11259922046 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 9, 2024
…stic#195616) Part of elastic#194171 Notice in the screen shot below, how opening Kibana home page loads async dashboard chunks. <img width="500" alt="Screenshot 2024-10-09 at 8 38 24 AM" src="https://github.com/user-attachments/assets/2cfdb512-03e4-4634-bb0c-a8d163f98540"> This PR replaces async import with a sync import. The page load bundle size increases but this is no different than the current behavior, just the import is now properly accounted for in page load stats. The next step is to resolve elastic#191642 and reduce the page load impact of registering uiActions (but this is out of scope for this PR). (cherry picked from commit 7448376)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 9, 2024
#195616) (#195655) # Backport This will backport the following commits from `main` to `8.x`: - [[dashboard] do not async import dashboard actions on plugin load (#195616)](#195616) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Nathan Reese","email":"reese.nathan@elastic.co"},"sourceCommit":{"committedDate":"2024-10-09T17:21:15Z","message":"[dashboard] do not async import dashboard actions on plugin load (#195616)\n\nPart of https://github.com/elastic/kibana/issues/194171\r\n\r\nNotice in the screen shot below, how opening Kibana home page loads\r\nasync dashboard chunks.\r\n<img width=\"500\" alt=\"Screenshot 2024-10-09 at 8 38 24 AM\"\r\nsrc=\"https://github.com/user-attachments/assets/2cfdb512-03e4-4634-bb0c-a8d163f98540\">\r\n\r\nThis PR replaces async import with a sync import. The page load bundle\r\nsize increases but this is no different than the current behavior, just\r\nthe import is now properly accounted for in page load stats. The next\r\nstep is to resolve #191642 and\r\nreduce the page load impact of registering uiActions (but this is out of\r\nscope for this PR).","sha":"7448376119aa1aad0888eb68449c1b15fd0852ac","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Presentation","release_note:skip","v9.0.0","v8.16.0","backport:version"],"title":"[dashboard] do not async import dashboard actions on plugin load","number":195616,"url":"https://github.com/elastic/kibana/pull/195616","mergeCommit":{"message":"[dashboard] do not async import dashboard actions on plugin load (#195616)\n\nPart of https://github.com/elastic/kibana/issues/194171\r\n\r\nNotice in the screen shot below, how opening Kibana home page loads\r\nasync dashboard chunks.\r\n<img width=\"500\" alt=\"Screenshot 2024-10-09 at 8 38 24 AM\"\r\nsrc=\"https://github.com/user-attachments/assets/2cfdb512-03e4-4634-bb0c-a8d163f98540\">\r\n\r\nThis PR replaces async import with a sync import. The page load bundle\r\nsize increases but this is no different than the current behavior, just\r\nthe import is now properly accounted for in page load stats. The next\r\nstep is to resolve #191642 and\r\nreduce the page load impact of registering uiActions (but this is out of\r\nscope for this PR).","sha":"7448376119aa1aad0888eb68449c1b15fd0852ac"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195616","number":195616,"mergeCommit":{"message":"[dashboard] do not async import dashboard actions on plugin load (#195616)\n\nPart of https://github.com/elastic/kibana/issues/194171\r\n\r\nNotice in the screen shot below, how opening Kibana home page loads\r\nasync dashboard chunks.\r\n<img width=\"500\" alt=\"Screenshot 2024-10-09 at 8 38 24 AM\"\r\nsrc=\"https://github.com/user-attachments/assets/2cfdb512-03e4-4634-bb0c-a8d163f98540\">\r\n\r\nThis PR replaces async import with a sync import. The page load bundle\r\nsize increases but this is no different than the current behavior, just\r\nthe import is now properly accounted for in page load stats. The next\r\nstep is to resolve #191642 and\r\nreduce the page load impact of registering uiActions (but this is out of\r\nscope for this PR).","sha":"7448376119aa1aad0888eb68449c1b15fd0852ac"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Nathan Reese <reese.nathan@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #194171
Notice in the screen shot below, how opening Kibana home page loads async dashboard chunks.
This PR replaces async import with a sync import. The page load bundle size increases but this is no different than the current behavior, just the import is now properly accounted for in page load stats. The next step is to resolve #191642 and reduce the page load impact of registering uiActions (but this is out of scope for this PR).