[ML] Fix assertion in the Trained Model UI tests #195566
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darnautov
added
:ml
release_note:skip
Contributor
|
Pinging @elastic/ml-ui (:ml) |
Contributor
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11254885940 |
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
cc @darnautov |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 9, 2024
## Summary Removes assertions for success toast messages that were deleted in elastic#194614 ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit a406acb)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
2 tasks
kibanamachine
added a commit
that referenced
this pull request
Oct 9, 2024
…5587) # Backport This will backport the following commits from `main` to `8.x`: - [[ML] Fix assertion in the Trained Model UI tests (#195566)](#195566) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Dima Arnautov","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-09T12:24:31Z","message":"[ML] Fix assertion in the Trained Model UI tests (#195566)\n\n## Summary\r\n\r\nRemoves assertions for success toast messages that were deleted in\r\nhttps://github.com//pull/194614\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"a406acba31ed05588ae21eed5d380722e32fbbb0","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":[":ml","release_note:skip","v9.0.0","Team:ML","v8.16.0","backport:version"],"title":"[ML] Fix assertion in the Trained Model UI tests ","number":195566,"url":"https://github.com/elastic/kibana/pull/195566","mergeCommit":{"message":"[ML] Fix assertion in the Trained Model UI tests (#195566)\n\n## Summary\r\n\r\nRemoves assertions for success toast messages that were deleted in\r\nhttps://github.com//pull/194614\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"a406acba31ed05588ae21eed5d380722e32fbbb0"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195566","number":195566,"mergeCommit":{"message":"[ML] Fix assertion in the Trained Model UI tests (#195566)\n\n## Summary\r\n\r\nRemoves assertions for success toast messages that were deleted in\r\nhttps://github.com//pull/194614\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"a406acba31ed05588ae21eed5d380722e32fbbb0"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Dima Arnautov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removes assertions for success toast messages that were deleted in #194614
Checklist