Skip to content

Conversation

@kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

…c#194614)

## Summary

- Updates Trained Models table layout
- Adds  the E5 model disclaimer
- Removes redundant success toasts about model download, deletion, and
start of a deployment

<img width="1504" alt="image"
src="https://github.com/user-attachments/assets/e151afca-a9bf-4b4e-9d8c-a87c86c83ef9">

### Checklist

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [x] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [x] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

(cherry picked from commit 88cf632)
@kibanamachine kibanamachine added the backport This PR is a backport of another PR label Oct 9, 2024
@kibanamachine kibanamachine enabled auto-merge (squash) October 9, 2024 08:38
@darnautov darnautov disabled auto-merge October 9, 2024 10:32
@darnautov
Copy link
Contributor

@elasticmachine merge upstream

@darnautov darnautov enabled auto-merge (squash) October 9, 2024 17:01
@darnautov darnautov merged commit 9bdf698 into elastic:8.x Oct 9, 2024
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #36 / Machine Learning anomaly detectors POST anomaly_detectors _forecast with spaces should delete forecast for user with permissions
  • [job] [logs] Jest Tests #20 / SolutionFilter when the owner is a single solution should call onChange with selected solution id when no option selected yet

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/ml-trained-models-utils 40 41 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 2.6MB 2.6MB +476.0B
indexManagement 681.7KB 682.2KB +476.0B
ml 4.6MB 4.6MB +1.4KB
searchInferenceEndpoints 67.1KB 67.5KB +476.0B
total +2.8KB
Unknown metric groups

API count

id before after diff
@kbn/ml-trained-models-utils 46 47 +1

History

cc @darnautov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants