[8.x] [Fleet] Adjust privileges for GET output and GET download_source endpoints (#194951)#195536
Merged
criamico merged 4 commits intoelastic:8.xfrom Oct 11, 2024
Merged
Conversation
…oints (elastic#194951) Fixes elastic#191266 ## Summary Updating the authz for following endpoints: - `GET /agent_download_sources` - `GET /agent_download_sources/{id}` - `GET /outputs` - `GET /outputs/{id}` They need to have `authz.fleet.readSettings || authz.fleet.readAgentPolicies` as they should be visible in the agent policy settings page as well. ### Testing - Enable feature flag `subfeaturePrivileges` - Create a role with following privileges:  - Create a user that has the previous role - Log in and go to any agent policy > settings - The download source and output fields should be filled and editable. They were previously empty, as the GET endpoints were failing with 403 Forbidden ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> (cherry picked from commit 14d5677) # Conflicts: # x-pack/plugins/fleet/server/routes/download_source/index.ts
1 task
botelastic
Bot
added
the
Team:Fleet
Contributor
|
Pinging @elastic/fleet (Team:Fleet) |
Member
Author
|
@elasticmachine merge upstream |
jen-huang
approved these changes
Oct 9, 2024
Member
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build Succeeded
Metrics [docs]
History
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.x:Questions ?
Please refer to the Backport tool documentation