Skip to content

[Security GenAI] Remove assistantBedrockChat feature flag#195461

Merged
stephmilovic merged 4 commits intoelastic:mainfrom
stephmilovic:flag_removal_816
Oct 8, 2024
Merged

[Security GenAI] Remove assistantBedrockChat feature flag#195461
stephmilovic merged 4 commits intoelastic:mainfrom
stephmilovic:flag_removal_816

Conversation

@stephmilovic
Copy link
Copy Markdown
Contributor

@stephmilovic stephmilovic commented Oct 8, 2024 •
edited by kibanamachine
Loading

Summary

The assistantBedrockChat feature flag was never properly implemented. It was set to true by default, with the assumption that adding it to kibana.dev.yml would switch it to false. However, we've since learned feature flags can only go from false to true. Therefore, when assistantBedrockChat was introduced in 8.15 it was always set to true. We are keeping the truthy paths in place and removing the flag in this PR.

  • Removes assistantBedrockChat feature flag
  • Removes code paths for ActionsClientSimpleChatModel from x-pack/plugins/elastic_assistant
  • Adds comments and tests for clarity in streaming handlers in default_assistant_graph/helpers.ts

@stephmilovic stephmilovic added release_note:fix v9.0.0 Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. backport:prev-minor Team:Security Generative AI Security Generative AI v8.16.0 labels Oct 8, 2024
@stephmilovic stephmilovic requested review from a team as code owners October 8, 2024 16:00
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Oct 8, 2024

Pinging @elastic/security-solution (Team: SecuritySolution)

@stephmilovic
Copy link
Copy Markdown
Contributor Author

stephmilovic commented Oct 8, 2024

@elasticmachine merge upstream

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Oct 8, 2024

⏳ Build in-progress, with failures

Failed CI Steps

Test Failures

  • [job] [logs] Serverless Osquery Cypress Tests #1 / Alert Event Details - Cases Case sees osquery results from last action and add to a case sees osquery results from last action and add to a case

History

@stephmilovic
Copy link
Copy Markdown
Contributor Author

stephmilovic commented Oct 8, 2024

@elasticmachine merge upstream

patrykkopycinski
patrykkopycinski reviewed Oct 8, 2024
View reviewed changes
Comment thread x-pack/plugins/elastic_assistant/server/lib/langchain/graphs/default_assistant_graph/helpers.ts
}
}
}
if (event.name === 'ActionsClientSimpleChatModel') {
Copy link
Copy Markdown
Contributor

@patrykkopycinski patrykkopycinski Oct 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

patrykkopycinski
patrykkopycinski approved these changes Oct 8, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@patrykkopycinski patrykkopycinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @stephmilovic!

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Oct 8, 2024

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 20.6MB 20.6MB -120.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
securitySolution 88.3KB 88.3KB -24.0B

History

@stephmilovic stephmilovic merged commit 38d0bdd into elastic:main Oct 8, 2024
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Oct 8, 2024

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11244770317

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Oct 8, 2024

💔 All backports failed

Status Branch Result
❌ 8.x Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 195461

Questions ?

Please refer to the Backport tool documentation

@stephmilovic stephmilovic mentioned this pull request Oct 8, 2024
Merged
@stephmilovic
Copy link
Copy Markdown
Contributor Author

stephmilovic commented Oct 8, 2024

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

stephmilovic added a commit that referenced this pull request Oct 9, 2024
@stephmilovic @elasticmachine
[8.x] [Security GenAI] Remove assistantBedrockChat feature flag (#1…
6b9c758 
…95461) (#195516)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Security GenAI] Remove `assistantBedrockChat` feature flag
(#195461)](#195461)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Steph
Milovic","email":"stephanie.milovic@elastic.co"},"sourceCommit":{"committedDate":"2024-10-08T22:31:05Z","message":"[Security
GenAI] Remove `assistantBedrockChat` feature flag
(#195461)","sha":"38d0bdd3deeb72ca4e502361fb0df1f68fa7f443","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","Team:
SecuritySolution","backport:prev-minor","Team:Security Generative
AI","v8.16.0"],"number":195461,"url":"https://github.com/elastic/kibana/pull/195461","mergeCommit":{"message":"[Security
GenAI] Remove `assistantBedrockChat` feature flag
(#195461)","sha":"38d0bdd3deeb72ca4e502361fb0df1f68fa7f443"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195461","number":195461,"mergeCommit":{"message":"[Security
GenAI] Remove `assistantBedrockChat` feature flag
(#195461)","sha":"38d0bdd3deeb72ca4e502361fb0df1f68fa7f443"}},{"branch":"8.x","label":"v8.16.0","labelRegex":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@patrykkopycinski patrykkopycinski patrykkopycinski approved these changes

Assignees

No one assigned

Labels

release_note:fix Team:Security Generative AI Security Generative AI Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.16.0 v9.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@stephmilovic @elasticmachine @kibanamachine @patrykkopycinski