Skip to content

[8.x] [Synthetics] Fix ping heatmap payload (#195107)#195439

Merged
kibanamachine merged 1 commit intoelastic:8.xfrom
kibanamachine:backport/8.x/pr-195107
Oct 8, 2024
Merged

[8.x] [Synthetics] Fix ping heatmap payload (#195107)#195439
kibanamachine merged 1 commit intoelastic:8.xfrom
kibanamachine:backport/8.x/pr-195107

Conversation

@kibanamachine
Copy link
Copy Markdown
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine added the backport This PR is a backport of another PR label Oct 8, 2024
@kibanamachine kibanamachine enabled auto-merge (squash) October 8, 2024 14:51
@botelastic botelastic Bot added ci:project-deploy-observability Create an Observability project Team:actionable-obs Formerly "obs-ux-management", responsible for SLO, o11y alerting, significant events, & synthetics. labels Oct 8, 2024
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

## Summary

We addressed elastic#180076 recently
with these two PRs:

- elastic#184177
- elastic#192508

We were seeing a strange error that was difficult to repro, so we put in
a best-effort patch that was still ineffective. The reason this issue
happens is because in the code it's possible to divide by 0, which
yields a value of `Infinity`, which at some point causes our interval
value supplied to the server route to be an empty string.

This patch will make it so that we never pass a value of 0 to be used in
the calculation of bucket sizes in this hook.

(cherry picked from commit 560d561)
@kibanamachine kibanamachine force-pushed the backport/8.x/pr-195107 branch from 0e7e2ec to 5eb092d Compare October 8, 2024 15:44
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Oct 8, 2024

💚 Build Succeeded

  • Buildkite Build
  • Commit: 5eb092d
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-195439-5eb092d11bc9

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
synthetics 1.2MB 1.2MB +11.0B

History

cc @justinkambic

@kibanamachine kibanamachine merged commit c6c4d20 into elastic:8.x Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR ci:project-deploy-observability Create an Observability project Team:actionable-obs Formerly "obs-ux-management", responsible for SLO, o11y alerting, significant events, & synthetics.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants