[Fleet] Add missing privilege callout in Integrations Policies table#195429
Merged
criamico merged 1 commit intoelastic:mainfrom Oct 9, 2024
Merged
[Fleet] Add missing privilege callout in Integrations Policies table#195429criamico merged 1 commit intoelastic:mainfrom
criamico merged 1 commit intoelastic:mainfrom
Conversation
criamico
added
Team:Fleet
Contributor
|
Pinging @elastic/fleet (Team:Fleet) |
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
cc @criamico |
Contributor
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11249945368 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 9, 2024
…lastic#195429) Fixes elastic#191800 ## Summary Add missing privilege callout in Integrations Policies table. Currently the route `app/integrations/detail/{pkgName}-{version}/policies` is available even though the policies tab is not visible with limited privileges. ### Testing - Install `osquery_manager` - Enable rbac feature flag - Create role with privileges  - Log in with user with the above role - Navigate to `app/integrations/detail/osquery_manager-1.14.0/policies` - Verify that a limited privileges callout is displayed  (cherry picked from commit c3c587b)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 9, 2024
…table (#195429) (#195534) # Backport This will backport the following commits from `main` to `8.x`: - [[Fleet] Add missing privilege callout in Integrations Policies table (#195429)](#195429) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Cristina Amico","email":"criamico@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-10-09T07:06:56Z","message":"[Fleet] Add missing privilege callout in Integrations Policies table (#195429)\n\nFixes https://github.com/elastic/kibana/issues/191800\r\n\r\n## Summary\r\nAdd missing privilege callout in Integrations Policies table. \r\nCurrently the route\r\n`app/integrations/detail/{pkgName}-{version}/policies` is available even\r\nthough the policies tab is not visible with limited privileges.\r\n\r\n### Testing \r\n- Install `osquery_manager`\r\n- Enable rbac feature flag\r\n- Create role with privileges\r\n\r\n- Log in with user with the above role\r\n- Navigate to `app/integrations/detail/osquery_manager-1.14.0/policies`\r\n- Verify that a limited privileges callout is displayed\r\n","sha":"c3c587bc50816ce570d442b805fe63cb8faee8cc","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v9.0.0","v8.16.0","backport:version"],"title":"[Fleet] Add missing privilege callout in Integrations Policies table","number":195429,"url":"https://github.com/elastic/kibana/pull/195429","mergeCommit":{"message":"[Fleet] Add missing privilege callout in Integrations Policies table (#195429)\n\nFixes https://github.com/elastic/kibana/issues/191800\r\n\r\n## Summary\r\nAdd missing privilege callout in Integrations Policies table. \r\nCurrently the route\r\n`app/integrations/detail/{pkgName}-{version}/policies` is available even\r\nthough the policies tab is not visible with limited privileges.\r\n\r\n### Testing \r\n- Install `osquery_manager`\r\n- Enable rbac feature flag\r\n- Create role with privileges\r\n\r\n- Log in with user with the above role\r\n- Navigate to `app/integrations/detail/osquery_manager-1.14.0/policies`\r\n- Verify that a limited privileges callout is displayed\r\n","sha":"c3c587bc50816ce570d442b805fe63cb8faee8cc"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195429","number":195429,"mergeCommit":{"message":"[Fleet] Add missing privilege callout in Integrations Policies table (#195429)\n\nFixes https://github.com/elastic/kibana/issues/191800\r\n\r\n## Summary\r\nAdd missing privilege callout in Integrations Policies table. \r\nCurrently the route\r\n`app/integrations/detail/{pkgName}-{version}/policies` is available even\r\nthough the policies tab is not visible with limited privileges.\r\n\r\n### Testing \r\n- Install `osquery_manager`\r\n- Enable rbac feature flag\r\n- Create role with privileges\r\n\r\n- Log in with user with the above role\r\n- Navigate to `app/integrations/detail/osquery_manager-1.14.0/policies`\r\n- Verify that a limited privileges callout is displayed\r\n","sha":"c3c587bc50816ce570d442b805fe63cb8faee8cc"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Cristina Amico <criamico@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #191800
Summary
Add missing privilege callout in Integrations Policies table.
Currently the route
app/integrations/detail/{pkgName}-{version}/policiesis available even though the policies tab is not visible with limited privileges.Testing
osquery_managerapp/integrations/detail/osquery_manager-1.14.0/policies