Skip to content

[Synthetics] Add warning if TLS config not set for Synthetics#195395

Merged
justinkambic merged 2 commits intoelastic:mainfrom
justinkambic:warn-if-missing-tls-config-synthetics-service
Oct 9, 2024
Merged

[Synthetics] Add warning if TLS config not set for Synthetics#195395
justinkambic merged 2 commits intoelastic:mainfrom
justinkambic:warn-if-missing-tls-config-synthetics-service

Conversation

@justinkambic
Copy link
Copy Markdown
Contributor

@justinkambic justinkambic commented Oct 8, 2024

Summary

Recently while debugging a production issue where the Synthetics plugin was receiving 401 errors while trying to reach the Synthetics Service health endpoint, we isolated that there was an issue with the mTLS handshake between Kibana and the service.

Unfortunately, we were unsure if there was some missing custom config (especially relevant in Serverless Kibana), or if the certificate values were not present in the first place.

Adding this warning will help us make this determination better in the future when reviewing Kibana logs, as we will be assured if the config is not defined via this warning.

@justinkambic justinkambic added release_note:skip Skip the PR/issue when compiling release notes v9.0.0 backport:prev-minor Team:actionable-obs Formerly "obs-ux-management", responsible for SLO, o11y alerting, significant events, & synthetics. v8.16.0 labels Oct 8, 2024
@justinkambic justinkambic self-assigned this Oct 8, 2024
@justinkambic justinkambic requested a review from a team as a code owner October 8, 2024 12:19
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@botelastic botelastic Bot added the ci:project-deploy-observability Create an Observability project label Oct 8, 2024
@v1v
Copy link
Copy Markdown
Member

v1v commented Oct 8, 2024

/oblt-deploy

Copy link
Copy Markdown
Member

@vigneshshanmugam vigneshshanmugam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@justinkambic justinkambic enabled auto-merge (squash) October 9, 2024 15:39
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Oct 9, 2024

💚 Build Succeeded

  • Buildkite Build
  • Commit: aca2e36
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-195395-aca2e36026f2

Metrics [docs]

✅ unchanged

History

cc @justinkambic

@justinkambic justinkambic merged commit 8e986a6 into elastic:main Oct 9, 2024
@kibanamachine
Copy link
Copy Markdown
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11260023565

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 9, 2024
…c#195395)

## Summary

Recently while debugging a production issue where the Synthetics plugin
was receiving 401 errors while trying to reach the Synthetics Service
health endpoint, we isolated that there was an issue with the mTLS
handshake between Kibana and the service.

Unfortunately, we were unsure if there was some missing custom config
(especially relevant in Serverless Kibana), or if the certificate values
were not present in the first place.

Adding this warning will help us make this determination better in the
future when reviewing Kibana logs, as we will be assured if the config
is not defined via this warning.

(cherry picked from commit 8e986a6)
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 9, 2024
…195395) (#195658)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Synthetics] Add warning if TLS config not set for Synthetics
(#195395)](#195395)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Justin
Kambic","email":"jk@elastic.co"},"sourceCommit":{"committedDate":"2024-10-09T17:27:49Z","message":"[Synthetics]
Add warning if TLS config not set for Synthetics (#195395)\n\n##
Summary\r\n\r\nRecently while debugging a production issue where the
Synthetics plugin\r\nwas receiving 401 errors while trying to reach the
Synthetics Service\r\nhealth endpoint, we isolated that there was an
issue with the mTLS\r\nhandshake between Kibana and the
service.\r\n\r\nUnfortunately, we were unsure if there was some missing
custom config\r\n(especially relevant in Serverless Kibana), or if the
certificate values\r\nwere not present in the first place.\r\n\r\nAdding
this warning will help us make this determination better in
the\r\nfuture when reviewing Kibana logs, as we will be assured if the
config\r\nis not defined via this
warning.","sha":"8e986a6dd945160d80d9b400f4acb7f9181d962a","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-management","v8.16.0"],"title":"[Synthetics]
Add warning if TLS config not set for
Synthetics","number":195395,"url":"https://github.com/elastic/kibana/pull/195395","mergeCommit":{"message":"[Synthetics]
Add warning if TLS config not set for Synthetics (#195395)\n\n##
Summary\r\n\r\nRecently while debugging a production issue where the
Synthetics plugin\r\nwas receiving 401 errors while trying to reach the
Synthetics Service\r\nhealth endpoint, we isolated that there was an
issue with the mTLS\r\nhandshake between Kibana and the
service.\r\n\r\nUnfortunately, we were unsure if there was some missing
custom config\r\n(especially relevant in Serverless Kibana), or if the
certificate values\r\nwere not present in the first place.\r\n\r\nAdding
this warning will help us make this determination better in
the\r\nfuture when reviewing Kibana logs, as we will be assured if the
config\r\nis not defined via this
warning.","sha":"8e986a6dd945160d80d9b400f4acb7f9181d962a"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195395","number":195395,"mergeCommit":{"message":"[Synthetics]
Add warning if TLS config not set for Synthetics (#195395)\n\n##
Summary\r\n\r\nRecently while debugging a production issue where the
Synthetics plugin\r\nwas receiving 401 errors while trying to reach the
Synthetics Service\r\nhealth endpoint, we isolated that there was an
issue with the mTLS\r\nhandshake between Kibana and the
service.\r\n\r\nUnfortunately, we were unsure if there was some missing
custom config\r\n(especially relevant in Serverless Kibana), or if the
certificate values\r\nwere not present in the first place.\r\n\r\nAdding
this warning will help us make this determination better in
the\r\nfuture when reviewing Kibana logs, as we will be assured if the
config\r\nis not defined via this
warning.","sha":"8e986a6dd945160d80d9b400f4acb7f9181d962a"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Justin Kambic <jk@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Team:actionable-obs Formerly "obs-ux-management", responsible for SLO, o11y alerting, significant events, & synthetics. v8.16.0 v9.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants