[Console] Delete unused sense models and unused files#195344
Merged
sabarasaba merged 8 commits intoelastic:mainfrom Oct 9, 2024
Merged
[Console] Delete unused sense models and unused files#195344sabarasaba merged 8 commits intoelastic:mainfrom
sabarasaba merged 8 commits intoelastic:mainfrom
Conversation
sabarasaba
added
Feature:Console
Contributor
|
Pinging @elastic/kibana-management (Team:Kibana Management) |
ElenaStoeva
approved these changes
Oct 9, 2024
Contributor
ElenaStoeva
left a comment
ElenaStoeva
left a comment
There was a problem hiding this comment.
Thanks for working on this, it's awesome to see so much redundant code being removed! Tested locally for regressions, changes lgtm with one small comment.
Contributor
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
Unknown metric groupsESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
History
cc @sabarasaba |
andreadelrio
approved these changes
Oct 9, 2024
Contributor
andreadelrio
left a comment
andreadelrio
left a comment
There was a problem hiding this comment.
Scss clean up looks good.
sabarasaba
added
backport:prev-minor
v8.16.0
and removed
backport:skip
Contributor
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11271208739 |
Contributor
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11271208748 |
sabarasaba
added a commit
to sabarasaba/kibana
that referenced
this pull request
Oct 10, 2024
(cherry picked from commit d273c07)
Member
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 10, 2024
(cherry picked from commit d273c07)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 10, 2024
…#195728) # Backport This will backport the following commits from `main` to `8.x`: - [[Console] Delete unused sense models and unused files (#195344)](#195344) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Ignacio Rivas","email":"rivasign@gmail.com"},"sourceCommit":{"committedDate":"2024-10-09T15:54:43Z","message":"[Console] Delete unused sense models and unused files (#195344)","sha":"d273c07edcc1d0ab00f73309a2fb385b43f6221b","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Console","Team:Kibana Management","release_note:skip","v9.0.0","backport:prev-minor","v8.16.0"],"title":"[Console] Delete unused sense models and unused files","number":195344,"url":"https://github.com/elastic/kibana/pull/195344","mergeCommit":{"message":"[Console] Delete unused sense models and unused files (#195344)","sha":"d273c07edcc1d0ab00f73309a2fb385b43f6221b"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195344","number":195344,"mergeCommit":{"message":"[Console] Delete unused sense models and unused files (#195344)","sha":"d273c07edcc1d0ab00f73309a2fb385b43f6221b"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Ignacio Rivas <rivasign@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
As part of the effort being made with #194533, this PR removes all instances and usage of Ace/sense editor in favour of monaco. Also deletes a bunch of files that were not being used.