[ResponseOps][Rules] Rule type selection modal content cut off on small screens due to lack of vertical scrolling#195234
Merged
georgianaonoleata1904 merged 3 commits intoelastic:mainfrom Oct 9, 2024
Conversation
…k of vertical scrolling
georgianaonoleata1904
added
release_note:skip
Contributor
|
Pinging @elastic/response-ops (Team:ResponseOps) |
cnasikas
added
the
bug
Contributor
|
I merged |
adcoelho
approved these changes
Oct 7, 2024
Contributor
adcoelho
left a comment
adcoelho
left a comment
There was a problem hiding this comment.
Tested and works as expected 👍
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
jcger
approved these changes
Oct 9, 2024
Contributor
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11251066290 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 9, 2024
…ll screens due to lack of vertical scrolling (elastic#195234) ## Summary Closes elastic#184048 - the rule type selection modal is now scrollable on smaller windows https://github.com/user-attachments/assets/47082b35-02a7-4b67-9a88-ee4200908bef Co-authored-by: Antonio <antonio.coelho@elastic.co> (cherry picked from commit 6df6724)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 9, 2024
…on small screens due to lack of vertical scrolling (#195234) (#195543) # Backport This will backport the following commits from `main` to `8.x`: - [[ResponseOps][Rules] Rule type selection modal content cut off on small screens due to lack of vertical scrolling (#195234)](#195234) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Georgiana-Andreea Onoleață","email":"georgiana.onoleata@elastic.co"},"sourceCommit":{"committedDate":"2024-10-09T08:22:57Z","message":"[ResponseOps][Rules] Rule type selection modal content cut off on small screens due to lack of vertical scrolling (#195234)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/184048\r\n\r\n- the rule type selection modal is now scrollable on smaller windows \r\n\r\n\r\nhttps://github.com/user-attachments/assets/47082b35-02a7-4b67-9a88-ee4200908bef\r\n\r\nCo-authored-by: Antonio <antonio.coelho@elastic.co>","sha":"6df672421d6df47cb3e8f86ab9448f021dabc871","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","Team:ResponseOps","v9.0.0","backport:prev-minor","v8.16.0"],"title":"[ResponseOps][Rules] Rule type selection modal content cut off on small screens due to lack of vertical scrolling","number":195234,"url":"https://github.com/elastic/kibana/pull/195234","mergeCommit":{"message":"[ResponseOps][Rules] Rule type selection modal content cut off on small screens due to lack of vertical scrolling (#195234)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/184048\r\n\r\n- the rule type selection modal is now scrollable on smaller windows \r\n\r\n\r\nhttps://github.com/user-attachments/assets/47082b35-02a7-4b67-9a88-ee4200908bef\r\n\r\nCo-authored-by: Antonio <antonio.coelho@elastic.co>","sha":"6df672421d6df47cb3e8f86ab9448f021dabc871"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195234","number":195234,"mergeCommit":{"message":"[ResponseOps][Rules] Rule type selection modal content cut off on small screens due to lack of vertical scrolling (#195234)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/184048\r\n\r\n- the rule type selection modal is now scrollable on smaller windows \r\n\r\n\r\nhttps://github.com/user-attachments/assets/47082b35-02a7-4b67-9a88-ee4200908bef\r\n\r\nCo-authored-by: Antonio <antonio.coelho@elastic.co>","sha":"6df672421d6df47cb3e8f86ab9448f021dabc871"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Georgiana-Andreea Onoleață <georgiana.onoleata@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #184048
Screen.Recording.2024-10-07.at.15.06.20.mov