Skip to content

[Lens][ES|QL] Do not refetch the attributes if the query hasn't changed #195196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stratoula merged 6 commits into from
Oct 9, 2024
Merged

[Lens][ES|QL] Do not refetch the attributes if the query hasn't changed #195196

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c076fe8
[Lens][ES|QL] Do not refetch the attributes if the query hasn't changed
stratoula Oct 7, 2024
c34267d
Merge branch 'main' into lens-esql-same-query-guard
stratoula Oct 9, 2024
6074b92
Merge branch 'main' into lens-esql-same-query-guard
stratoula Oct 9, 2024
e692b80
Making MarcoV happy
stratoula Oct 9, 2024
be33c85
Move the comment too
stratoula Oct 9, 2024
c1d196b
Merge branch 'main' into lens-esql-same-query-guard
stratoula Oct 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions x-pack/plugins/lens/public/app_plugin/shared/edit_on_the_fly/lens_configuration_flyout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,6 +337,7 @@ export function LensEditConfigurationFlyout({
setErrors([]);
updateSuggestion?.(attrs);
}
prevQuery.current = q;
setIsVisualizationLoading(false);
},
[
Expand Down Expand Up @@ -481,7 +482,6 @@ export function LensEditConfigurationFlyout({
query={query}
onTextLangQueryChange={(q) => {
setQuery(q);
prevQuery.current = q;
}}
detectedTimestamp={adHocDataViews?.[0]?.timeFieldName}
hideTimeFilterInfo={hideTimeFilterInfo}
Expand All @@ -497,7 +497,8 @@ export function LensEditConfigurationFlyout({
editorIsInline
hideRunQueryText
onTextLangQuerySubmit={async (q, a) => {
if (q) {
// do not run the suggestions if the query is the same as the previous one
if (q && !isEqual(q, prevQuery.current)) {
setIsVisualizationLoading(true);
await runQuery(q, a);
}
Expand Down