[Security Solution] Add upgrade prebuilt rule flyout layout details #195166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maximpn
added
release_note:skip
maximpn
force-pushed
the
add-layout-details
branch
from
80b7bb2
to
2dd77d2
Compare
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: cc @maximpn |
|
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
|
Pinging @elastic/security-detection-rule-management (Team:Detection Rule Management) |
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
cc @maximpn |
nikitaindik
approved these changes
Oct 10, 2024
There was a problem hiding this comment.
Thanks @maximpn! I have checked the changes without running them locally, and they look good to me. Let's merge it so I can incorporate these changes into my PR and we can see how it all works in combination.
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11271554595 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 10, 2024
…lastic#195166) **Addresses:** elastic#171520 **Design:** [Figma](https://www.figma.com/file/gLHm8LpTtSkAUQHrkG3RHU/%5B8.7%5D-%5BRules%5D-Rule-Immutability%2FCustomization?type=design&node-id=3903%3A88369&mode=design&t=rMjxtGjBNKbCjedE-1) (internal) ## Summary This PR extends prebuilt rule flyout layout with design details including field state, rule state callout and little UI fixes. ## Screenshots <img width="1287" alt="image" src="https://github.com/user-attachments/assets/74846530-7874-4958-9f4f-e4477027591b"> <img width="1279" alt="image" src="https://github.com/user-attachments/assets/cf87fd84-f041-4142-b051-d9d7dd846733"> <img width="1276" alt="image" src="https://github.com/user-attachments/assets/d6f3c9e5-d837-43b6-8728-d8a23095ed2c"> (cherry picked from commit 4d54cfe)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 10, 2024
…ails (#195166) (#195730) # Backport This will backport the following commits from `main` to `8.x`: - [[Security Solution] Add upgrade prebuilt rule flyout layout details (#195166)](#195166) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Maxim Palenov","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-10T09:44:56Z","message":"[Security Solution] Add upgrade prebuilt rule flyout layout details (#195166)\n\n**Addresses:** https://github.com/elastic/kibana/issues/171520\r\n**Design:**\r\n[Figma](https://www.figma.com/file/gLHm8LpTtSkAUQHrkG3RHU/%5B8.7%5D-%5BRules%5D-Rule-Immutability%2FCustomization?type=design&node-id=3903%3A88369&mode=design&t=rMjxtGjBNKbCjedE-1)\r\n(internal)\r\n\r\n## Summary\r\n\r\nThis PR extends prebuilt rule flyout layout with design details\r\nincluding field state, rule state callout and little UI fixes.\r\n\r\n## Screenshots\r\n\r\n<img width=\"1287\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/74846530-7874-4958-9f4f-e4477027591b\">\r\n\r\n<img width=\"1279\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/cf87fd84-f041-4142-b051-d9d7dd846733\">\r\n\r\n<img width=\"1276\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/d6f3c9e5-d837-43b6-8728-d8a23095ed2c\">","sha":"4d54cfe2bc3d28d238bc3d56186692081a5d5a9c","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Detections and Resp","Team: SecuritySolution","Team:Detection Rule Management","Feature:Prebuilt Detection Rules","backport:prev-minor"],"title":"[Security Solution] Add upgrade prebuilt rule flyout layout details","number":195166,"url":"https://github.com/elastic/kibana/pull/195166","mergeCommit":{"message":"[Security Solution] Add upgrade prebuilt rule flyout layout details (#195166)\n\n**Addresses:** https://github.com/elastic/kibana/issues/171520\r\n**Design:**\r\n[Figma](https://www.figma.com/file/gLHm8LpTtSkAUQHrkG3RHU/%5B8.7%5D-%5BRules%5D-Rule-Immutability%2FCustomization?type=design&node-id=3903%3A88369&mode=design&t=rMjxtGjBNKbCjedE-1)\r\n(internal)\r\n\r\n## Summary\r\n\r\nThis PR extends prebuilt rule flyout layout with design details\r\nincluding field state, rule state callout and little UI fixes.\r\n\r\n## Screenshots\r\n\r\n<img width=\"1287\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/74846530-7874-4958-9f4f-e4477027591b\">\r\n\r\n<img width=\"1279\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/cf87fd84-f041-4142-b051-d9d7dd846733\">\r\n\r\n<img width=\"1276\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/d6f3c9e5-d837-43b6-8728-d8a23095ed2c\">","sha":"4d54cfe2bc3d28d238bc3d56186692081a5d5a9c"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195166","number":195166,"mergeCommit":{"message":"[Security Solution] Add upgrade prebuilt rule flyout layout details (#195166)\n\n**Addresses:** https://github.com/elastic/kibana/issues/171520\r\n**Design:**\r\n[Figma](https://www.figma.com/file/gLHm8LpTtSkAUQHrkG3RHU/%5B8.7%5D-%5BRules%5D-Rule-Immutability%2FCustomization?type=design&node-id=3903%3A88369&mode=design&t=rMjxtGjBNKbCjedE-1)\r\n(internal)\r\n\r\n## Summary\r\n\r\nThis PR extends prebuilt rule flyout layout with design details\r\nincluding field state, rule state callout and little UI fixes.\r\n\r\n## Screenshots\r\n\r\n<img width=\"1287\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/74846530-7874-4958-9f4f-e4477027591b\">\r\n\r\n<img width=\"1279\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/cf87fd84-f041-4142-b051-d9d7dd846733\">\r\n\r\n<img width=\"1276\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/d6f3c9e5-d837-43b6-8728-d8a23095ed2c\">","sha":"4d54cfe2bc3d28d238bc3d56186692081a5d5a9c"}}]}] BACKPORT--> Co-authored-by: Maxim Palenov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: #171520
Design: Figma (internal)
Summary
This PR extends prebuilt rule flyout layout with design details including field state, rule state callout and little UI fixes.
Screenshots