Skip to content

[8.x] Implement new nav hierarchy for stateful/cloud (#192805)#194912

Merged
kibanamachine merged 1 commit intoelastic:8.xfrom
kibanamachine:backport/8.x/pr-192805
Oct 4, 2024
Merged

[8.x] Implement new nav hierarchy for stateful/cloud (#192805)#194912
kibanamachine merged 1 commit intoelastic:8.xfrom
kibanamachine:backport/8.x/pr-192805

Conversation

@kibanamachine
Copy link
Copy Markdown
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

<strike>Depends on elastic#193526,
WON'T FIX</strike>

Fixes elastic#192803
Fixes elastic#191509

This PR updates the nav hierarchy for stateful/cloud and changes the
`accordion` to `panelOpener`. The menu items have been updated according
to the Figma file and the discussions happening in this
[issue](elastic#192050). I took a video
below of how the new navigation looks like with the new changes

https://github.com/user-attachments/assets/e73c8dd9-b674-4146-bcde-443490569502

## What was changed
- AI & ML menu is removed and split into
  - `AI Assistant`
- `Machine learning`: this menu was already present in the footer, it
was moved in the body (after Infrastucture)
- `Applications` now opens a `panelOpener` instead of an `accordion`
  - Synthetics was moved to a new section
  - “User Experience” was renamed to “User experience”
- `Infrastucture` now opens a `panelOpener` instead of an `accordion`
  - Universal Profiling was moved to a separate section below
  - Metrics Explorer was renamed to Metrics explorer
- `Machine learning` now opens a `panelOpener` instead of an `accordion`
- `Supplied Configurations` was added under the Machine learning >
Anomaly Detection section.
- The machine learning `link:
'securitySolutionUI:machine_learning-landing'` was completely removed.
Clicking on the `Machine learning` link will slide out the panel instead
(same behavior with clicking on the icon). More details about why I
removed this
[here](elastic#192805 (comment))
  - Use sentence/case for the menu items
- `Other tools` now opens a `panelOpener` instead of an `accordion`
  - Logs anomalies was added here
  - Logs categories was added here
  - Visualize library was added
- Clicking on the 1st level menu items (Applications, Infrastructure,
Machine learning, Other tools) toggles the panel on the right
(arrowRight).
- The icon was changed from the four small squares to the right-facing
caret
- The sub-nav menu slides out to the right whenever the label OR the
icon are clicked
- `Getting started` in the footer was renamed to `Add data`
- `Data Set Quality` was added under `Stack Management > Data` section
below `Index Management`

## Functional Tests
Some tests have been added that test:
- toggling of the panel when clicking on the link button
- `AI assistant` changes
- `Infrastructure` changes
- `Other Tools` changes
- `Machine Learning` changes

## What this PR doesn't do
I faced some issues with the footer, so footer will be separately
handled in this [issue](elastic#192865)

---------

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Sébastien Loix <sebastien.loix@elastic.co>
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Dominique Clarke <dominique.clarke@elastic.co>
(cherry picked from commit ab71509)
@kibanamachine kibanamachine added the backport This PR is a backport of another PR label Oct 4, 2024
@kibanamachine kibanamachine enabled auto-merge (squash) October 4, 2024 08:07
@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:actionable-obs Formerly "obs-ux-management", responsible for SLO, o11y alerting, significant events, & synthetics. labels Oct 4, 2024
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@kibanamachine kibanamachine merged commit c483318 into elastic:8.x Oct 4, 2024
@kibana-ci
Copy link
Copy Markdown

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
navigation 23.8KB 24.1KB +238.0B
observability 467.2KB 467.5KB +341.0B
serverless 24.5KB 24.7KB +237.0B
total +816.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 455.9KB 455.8KB -155.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @mgiota

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR ci:project-deploy-observability Create an Observability project Team:actionable-obs Formerly "obs-ux-management", responsible for SLO, o11y alerting, significant events, & synthetics.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants