Skip to content

[Security Solution][Detection Engine] fix cypress MKI flaky test #194866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vitaliidm merged 13 commits into from
Oct 9, 2024
Merged

[Security Solution][Detection Engine] fix cypress MKI flaky test #194866

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
9050078
investigate cypress MKI flaky tests
vitaliidm Oct 3, 2024
cc3160c
test
vitaliidm Oct 3, 2024
d606b2d
Update threshold_rule.cy.ts
vitaliidm Oct 3, 2024
f1aa87d
attempt to rewrite test
vitaliidm Oct 4, 2024
542b4cb
Merge branch 'de_8_16/threshold_suppression_flaky_cy_test' of https:/…
vitaliidm Oct 4, 2024
4a47627
intended failure of test
vitaliidm Oct 4, 2024
11f8925
Merge branch 'main' into de_8_16/threshold_suppression_flaky_cy_test
vitaliidm Oct 4, 2024
e5faf01
Update package.json
vitaliidm Oct 4, 2024
1409874
Update threshold_rule.cy.ts
vitaliidm Oct 4, 2024
73d0c0d
remove EOF
vitaliidm Oct 4, 2024
21c1484
Merge branch 'main' into de_8_16/threshold_suppression_flaky_cy_test
vitaliidm Oct 4, 2024
e6d79cd
Update threshold_rule.cy.ts
vitaliidm Oct 4, 2024
3d46de6
Merge branch 'main' into de_8_16/threshold_suppression_flaky_cy_test
rylnd Oct 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions ...ypress/cypress/e2e/detection_response/detection_engine/rule_creation/threshold_rule.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,8 @@ import {
fillScheduleRuleAndContinue,
selectThresholdRuleType,
waitForAlertsToPopulate,
fillDefineThresholdRule,
continueFromDefineStep,
} from '../../../../tasks/create_new_rule';
import { login } from '../../../../tasks/login';
import { visit } from '../../../../tasks/navigation';
Expand All @@ -68,7 +70,7 @@ import { CREATE_RULE_URL } from '../../../../urls/navigation';
describe(
'Threshold rules',
{
tags: ['@ess', '@serverless', '@skipInServerlessMKI'],
tags: ['@ess', '@serverless'],
},
() => {
const rule = getNewThresholdRule();
Expand Down Expand Up @@ -152,8 +154,10 @@ describe(
it('Creates a new threshold rule with suppression enabled', () => {
selectThresholdRuleType();

fillDefineThresholdRule(rule);
enablesAndPopulatesThresholdSuppression(5, 'h');
fillDefineThresholdRuleAndContinue(rule);
continueFromDefineStep();

// ensures duration displayed on define step in preview mode
cy.get(DEFINITION_DETAILS).within(() => {
getDetails(SUPPRESS_FOR_DETAILS).should('have.text', '5h');
Expand Down
9 changes: 7 additions & 2 deletions x-pack/test/security_solution_cypress/cypress/tasks/create_new_rule.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -557,7 +557,7 @@ export const fillRuleActionFilters = (alertsFilter: AlertsFilter) => {
.type(`{selectall}${alertsFilter.timeframe.timezone}{enter}`);
};

export const fillDefineThresholdRuleAndContinue = (rule: ThresholdRuleCreateProps) => {
export const fillDefineThresholdRule = (rule: ThresholdRuleCreateProps) => {
const thresholdField = 0;
const threshold = 1;

Expand All @@ -578,7 +578,11 @@ export const fillDefineThresholdRuleAndContinue = (rule: ThresholdRuleCreateProp
cy.wrap(inputs[threshold]).clear();
cy.wrap(inputs[threshold]).type(`${rule.threshold.value}`);
});
cy.get(DEFINE_CONTINUE_BUTTON).should('exist').click({ force: true });
};

export const fillDefineThresholdRuleAndContinue = (rule: ThresholdRuleCreateProps) => {
fillDefineThresholdRule(rule);
continueFromDefineStep();
};

export const fillDefineEqlRule = (rule: EqlRuleCreateProps) => {
Expand Down Expand Up @@ -908,6 +912,7 @@ export const enablesAndPopulatesThresholdSuppression = (
// enables suppression for threshold rule
cy.get(THRESHOLD_ENABLE_SUPPRESSION_CHECKBOX).should('not.be.checked');
cy.get(THRESHOLD_ENABLE_SUPPRESSION_CHECKBOX).click();
cy.get(THRESHOLD_ENABLE_SUPPRESSION_CHECKBOX).should('be.checked');

setAlertSuppressionDuration(interval, timeUnit);

Expand Down