[EDR Workflows] Deprecate public endpoint/suggestions api endpoint in favour of an internal one #194832
Merged
szwarckonrad merged 16 commits intoelastic:mainfrom Oct 8, 2024
Conversation
szwarckonrad
added
release_note:skip
Contributor
|
Pinging @elastic/security-defend-workflows (Team:Defend Workflows) |
paul-tavares
reviewed
Oct 7, 2024
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
Contributor
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11236616061 |
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 8, 2024
… favour of an internal one (elastic#194832) New internal GET `/internal/api/endpoint/suggestions/{suggestion_type}` route. Current public GET `/api/endpoint/suggestions/{suggestion_type}` route is set to deprecated. UI uses now the internal GET `/internal/api/endpoint/suggestions/{suggestion_type}` api route --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit ef4755a)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
1 task
kibanamachine
added a commit
that referenced
this pull request
Oct 8, 2024
…int in favour of an internal one (#194832) (#195416) # Backport This will backport the following commits from `main` to `8.x`: - [[EDR Workflows] Deprecate public endpoint/suggestions api endpoint in favour of an internal one (#194832)](#194832) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Konrad Szwarc","email":"konrad.szwarc@elastic.co"},"sourceCommit":{"committedDate":"2024-10-08T13:34:27Z","message":"[EDR Workflows] Deprecate public endpoint/suggestions api endpoint in favour of an internal one (#194832)\n\nNew internal GET `/internal/api/endpoint/suggestions/{suggestion_type}`\r\nroute.\r\n\r\nCurrent public GET `/api/endpoint/suggestions/{suggestion_type}` route\r\nis set to deprecated.\r\n\r\n\r\nUI uses now the internal GET\r\n`/internal/api/endpoint/suggestions/{suggestion_type}` api route\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"ef4755a063e5e08af3ebd44c2a866ac804eabcd4","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Defend Workflows","v8.16.0","backport:version"],"title":"[EDR Workflows] Deprecate public endpoint/suggestions api endpoint in favour of an internal one ","number":194832,"url":"https://github.com/elastic/kibana/pull/194832","mergeCommit":{"message":"[EDR Workflows] Deprecate public endpoint/suggestions api endpoint in favour of an internal one (#194832)\n\nNew internal GET `/internal/api/endpoint/suggestions/{suggestion_type}`\r\nroute.\r\n\r\nCurrent public GET `/api/endpoint/suggestions/{suggestion_type}` route\r\nis set to deprecated.\r\n\r\n\r\nUI uses now the internal GET\r\n`/internal/api/endpoint/suggestions/{suggestion_type}` api route\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"ef4755a063e5e08af3ebd44c2a866ac804eabcd4"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/194832","number":194832,"mergeCommit":{"message":"[EDR Workflows] Deprecate public endpoint/suggestions api endpoint in favour of an internal one (#194832)\n\nNew internal GET `/internal/api/endpoint/suggestions/{suggestion_type}`\r\nroute.\r\n\r\nCurrent public GET `/api/endpoint/suggestions/{suggestion_type}` route\r\nis set to deprecated.\r\n\r\n\r\nUI uses now the internal GET\r\n`/internal/api/endpoint/suggestions/{suggestion_type}` api route\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"ef4755a063e5e08af3ebd44c2a866ac804eabcd4"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Konrad Szwarc <konrad.szwarc@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New internal GET
/internal/api/endpoint/suggestions/{suggestion_type}route.Current public GET
/api/endpoint/suggestions/{suggestion_type}route is set to deprecated.UI uses now the internal GET
/internal/api/endpoint/suggestions/{suggestion_type}api route