Skip to content

[EDR Workflows] Deprecate public metadata/transforms api endpoint in favour of an internal one#194829

Merged
szwarckonrad merged 20 commits intoelastic:mainfrom
szwarckonrad:deprecate-public-transforms-endpoint
Oct 9, 2024
Merged

[EDR Workflows] Deprecate public metadata/transforms api endpoint in favour of an internal one#194829
szwarckonrad merged 20 commits intoelastic:mainfrom
szwarckonrad:deprecate-public-transforms-endpoint

Conversation

@szwarckonrad
Copy link
Copy Markdown
Contributor

@szwarckonrad szwarckonrad commented Oct 3, 2024

New internal GET /api/endpoint/metadata/transforms route.

Current public GET /api/endpoint/metadata/transforms route is set to deprecated.

All usages across the project have been updated to consume the new internal route.

@szwarckonrad szwarckonrad self-assigned this Oct 3, 2024
@szwarckonrad szwarckonrad added release_note:skip Skip the PR/issue when compiling release notes v9.0.0 Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.16.0 backport:version Backport to applied version labels labels Oct 3, 2024
@szwarckonrad szwarckonrad requested a review from joeypoon October 7, 2024 08:51
@szwarckonrad szwarckonrad marked this pull request as ready for review October 7, 2024 08:51
@szwarckonrad szwarckonrad requested a review from a team as a code owner October 7, 2024 08:51
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/security-defend-workflows (Team:Defend Workflows)

@kibana-ci
Copy link
Copy Markdown

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @szwarckonrad

Copy link
Copy Markdown
Member

@joeypoon joeypoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for updating this 👌

@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

cc @szwarckonrad

@szwarckonrad szwarckonrad merged commit 15abb85 into elastic:main Oct 9, 2024
@kibanamachine
Copy link
Copy Markdown
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11253014323

kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Oct 9, 2024
…favour of an internal one (elastic#194829)

New internal GET `/api/endpoint/metadata/transforms` route.

Current public GET `/api/endpoint/metadata/transforms` route is set to
deprecated.

All usages across the project have been updated to consume the new
internal route.

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 15abb85)
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 9, 2024
…nt in favour of an internal one (#194829) (#195565)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[EDR Workflows] Deprecate public metadata/transforms api endpoint in
favour of an internal one
(#194829)](#194829)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Konrad
Szwarc","email":"konrad.szwarc@elastic.co"},"sourceCommit":{"committedDate":"2024-10-09T10:21:55Z","message":"[EDR
Workflows] Deprecate public metadata/transforms api endpoint in favour
of an internal one (#194829)\n\nNew internal GET
`/api/endpoint/metadata/transforms` route.\r\n\r\nCurrent public GET
`/api/endpoint/metadata/transforms` route is set
to\r\ndeprecated.\r\n\r\nAll usages across the project have been updated
to consume the new\r\ninternal
route.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"15abb859920fc2132eaf7c519c18ca39577acaf1","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Defend
Workflows","v8.16.0","backport:version"],"title":"[EDR Workflows]
Deprecate public metadata/transforms api endpoint in favour of an
internal
one","number":194829,"url":"https://github.com/elastic/kibana/pull/194829","mergeCommit":{"message":"[EDR
Workflows] Deprecate public metadata/transforms api endpoint in favour
of an internal one (#194829)\n\nNew internal GET
`/api/endpoint/metadata/transforms` route.\r\n\r\nCurrent public GET
`/api/endpoint/metadata/transforms` route is set
to\r\ndeprecated.\r\n\r\nAll usages across the project have been updated
to consume the new\r\ninternal
route.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"15abb859920fc2132eaf7c519c18ca39577acaf1"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/194829","number":194829,"mergeCommit":{"message":"[EDR
Workflows] Deprecate public metadata/transforms api endpoint in favour
of an internal one (#194829)\n\nNew internal GET
`/api/endpoint/metadata/transforms` route.\r\n\r\nCurrent public GET
`/api/endpoint/metadata/transforms` route is set
to\r\ndeprecated.\r\n\r\nAll usages across the project have been updated
to consume the new\r\ninternal
route.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"15abb859920fc2132eaf7c519c18ca39577acaf1"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Konrad Szwarc <konrad.szwarc@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.16.0 v9.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants