Skip to content

Add sys_monitoring query param to fleet oas#194767

Closed
daemitus wants to merge 2 commits intoelastic:mainfrom
daemitus:sys_monitoring
Closed

Add sys_monitoring query param to fleet oas#194767
daemitus wants to merge 2 commits intoelastic:mainfrom
daemitus:sys_monitoring

Conversation

@daemitus
Copy link
Copy Markdown

@daemitus daemitus commented Oct 2, 2024

Summary

I'm upstreaming some issues I've noticed in the elasticstack Terraform provider.

Adds the missing sys_monitoring query param to oas.
POST /api/fleet/agent_policies?sys_monitoring=true

See:

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@daemitus daemitus requested a review from a team as a code owner October 2, 2024 22:05
@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Oct 2, 2024
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/fleet (Team:Fleet)

@kpollich
Copy link
Copy Markdown
Member

kpollich commented Oct 3, 2024

Thanks for the PR @daemitus, and for your help on the Terraform provider issue we chatted on previously.

@juliaElastic - Do we need to update the router code for this now that we're using the code-gen tool for OpenAPI specs?

@daemitus
Copy link
Copy Markdown
Author

daemitus commented Oct 3, 2024

if something is generating parts of the oas docs, point me to it. I want to pull in the rest of the fixes in the terraform provider at some point.

@juliaElastic
Copy link
Copy Markdown
Contributor

juliaElastic commented Oct 3, 2024

This is the issue that will enable generating oas, see the linked pull requests. #184685

sys_monitoring is already there in the request schema code:

sys_monitoring: schema.maybe(schema.boolean()),

@daemitus
Copy link
Copy Markdown
Author

daemitus commented Oct 3, 2024

I can look into using this, looks like it's going to get merged shortly.

@daemitus daemitus closed this Oct 3, 2024
@daemitus daemitus deleted the sys_monitoring branch October 3, 2024 14:31
@daemitus
Copy link
Copy Markdown
Author

daemitus commented Oct 3, 2024

as a sidenote @juliaElastic , is the operationID editable in the rest_spec such that it shows up downstream in the generated oas? You're losing alot of nuance with "operationID": ''%2Fapi%2Ffleet%2Fepm%2Fpackages%2F%7BpkgName%7D%2F%7BpkgVersion%7D#3" where-as the current output has

operationId: install-package 
summary: Install package

Looks like the docs here use summary and maybe opID, or just the summary kebab-cased together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

💝community Team:Fleet Team label for Observability Data Collection Fleet team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants