[8.x] Move nested declarations above rule (#193931)#194598
Merged
kibanamachine merged 1 commit intoelastic:8.xfrom Oct 1, 2024
Merged
[8.x] Move nested declarations above rule (#193931)#194598kibanamachine merged 1 commit intoelastic:8.xfrom
kibanamachine merged 1 commit intoelastic:8.xfrom
Conversation
## Summary
> Sass's behavior for declarations that appear after nested
rules will be changing to match the behavior specified by CSS in an
upcoming
version. To keep the existing behavior, move the declaration above the
nested
rule. To opt into the new behavior, wrap the declaration in & {}.
I have moved the declarations above the nested rules.
I had attempted to opt in to the new behavior, but the resulting CSS has
duplicate selectors, which CI does not allow
For more information about the new behavior, see
[here](https://sass-lang.com/documentation/breaking-changes/mixed-decls/)
Closes elastic#190898
[screenshots](elastic#193931 (comment))
Closes elastic#190899
[screenshots](elastic#193931 (comment))
Closes elastic#190900 Access Page uses
`authentication_state_page`, but I was unable to find
'overwrite_session` and `logged_out` pages
Closes elastic#190901
[screenshots](elastic#193931 (comment))
Closes elastic#190902 ^used on same UI
Closes elastic#190903
[screenshots](elastic#193931 (comment))
Closes elastic#190904
[screenshots](elastic#193931 (comment))
(cherry picked from commit c8c7439)
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
To update your PR or re-run it, just comment with: cc @kc13greiner |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.x:Questions ?
Please refer to the Backport tool documentation