Skip to content

[Observability Onboarding] Update onboarding landing page#194565

Merged
thomheymann merged 11 commits intoelastic:mainfrom
thomheymann:3775-landing-page
Oct 7, 2024
Merged

[Observability Onboarding] Update onboarding landing page#194565
thomheymann merged 11 commits intoelastic:mainfrom
thomheymann:3775-landing-page

Conversation

@thomheymann
Copy link
Copy Markdown
Contributor

@thomheymann thomheymann commented Oct 1, 2024 •
edited by kibanamachine
Loading

Resolves https://github.com/elastic/observability-dev/issues/3775
Resolves #192949

Summary

Updates the "add data" page according to new design

Screenshot 2024-10-01 at 12 36 15

@thomheymann thomheymann added release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor labels Oct 1, 2024
@obltmachine
Copy link
Copy Markdown

obltmachine commented Oct 1, 2024

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@thomheymann thomheymann marked this pull request as ready for review October 2, 2024 09:07
@thomheymann thomheymann requested a review from a team as a code owner October 2, 2024 09:07
@thomheymann thomheymann requested a review from a team October 2, 2024 09:07
@botelastic botelastic Bot added the ci:project-deploy-observability Create an Observability project label Oct 2, 2024
@mykolaharmash
Copy link
Copy Markdown
Contributor

mykolaharmash commented Oct 2, 2024

Looks great! ✨

A few design notes:

Could we make icons in the category cards stick to the bottom of the card? Similar to the integration cards. Otherwise it looks misaligned (noticeable on the Cloud category). Also icons in Figma seem to have larger spacing.

CleanShot 2024-10-02 at 15 38 55@2x

Love the Apple and Linux logos! Though they look misaligned a bit because of different visual center of mass. In Figma, Christian seems to account for that by positioning Linux logo a bit lower, could we add a custom padding as well?

CleanShot 2024-10-02 at 15 41 32@2x

Also, search bar doesn't take the full width like in the designs.

mykolaharmash
mykolaharmash reviewed Oct 2, 2024
View reviewed changes
Comment thread x-pack/plugins/observability_solution/observability_onboarding/public/assets/linux.svg
Copy link
Copy Markdown
Contributor

@mykolaharmash mykolaharmash Oct 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This logo is almost 700KB, I think it makes sense to have it just as 2x jpeg. wdyt?

Copy link
Copy Markdown
Contributor Author

@thomheymann thomheymann Oct 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. I would leave it as is though for the following reasons:

  • The image is loaded in async and does not increase the JS bundle size and does not block time to first paint or time to interactive.
  • The image is transferred gzipped so comes closer to 324 KB. That's still big for a tiny icon but nothing unusual or concerning for modern web graphics.

Comment thread ...on/observability_onboarding/public/application/onboarding_flow_form/onboarding_flow_form.tsx
@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Oct 4, 2024 •
edited
Loading

💚 Build Succeeded

  • Buildkite Build
  • Commit: 4425f36
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-194565-4425f36b44ad

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
observabilityOnboarding 255 253 -2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observabilityOnboarding 273.0KB 273.6KB +587.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mykolaharmash
Copy link
Copy Markdown
Contributor

mykolaharmash commented Oct 7, 2024

Thank you for addressing comments, looks great ✨

@thomheymann thomheymann enabled auto-merge (squash) October 7, 2024 20:17
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Oct 7, 2024 •
edited
Loading

💚 Build Succeeded

  • Buildkite Build
  • Commit: dc16618
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-194565-dc16618ad606

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
observabilityOnboarding 255 253 -2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observabilityOnboarding 273.0KB 273.6KB +587.0B

History

@thomheymann thomheymann merged commit 28d6a22 into elastic:main Oct 7, 2024
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Oct 7, 2024

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11225047399

kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Oct 7, 2024
@thomheymann @kibanamachine
[Observability Onboarding] Update onboarding landing page (elastic#19…
40c7fa0 
…4565)

Resolves elastic/observability-dev#3775
Resolves elastic#192949

## Summary

Updates the "add data" page according to new design

<img width="1448" alt="Screenshot 2024-10-01 at 12 36 15"
src="https://github.com/user-attachments/assets/1301a487-d3b9-4d6f-ad5d-f88d2cfc029d">

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 28d6a22)
@kibanamachine kibanamachine mentioned this pull request Oct 7, 2024
Merged
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Oct 7, 2024

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine mentioned this pull request Oct 8, 2024
Merged
1 task
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 8, 2024
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Oct 8, 2024

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

4 similar comments
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Oct 9, 2024

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Oct 11, 2024

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Oct 14, 2024

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Oct 15, 2024

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

kibanamachine added a commit that referenced this pull request Oct 15, 2024
@kibanamachine @thomheymann
[8.x] [Observability Onboarding] Update onboarding landing page (#194565
d7ee2da 
) (#195329)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Observability Onboarding] Update onboarding landing page
(#194565)](#194565)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Thom
Heymann","email":"190132+thomheymann@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-10-07T22:31:52Z","message":"[Observability
Onboarding] Update onboarding landing page (#194565)\n\nResolves
https://github.com/elastic/observability-dev/issues/3775\r\nResolves
https://github.com/elastic/kibana/issues/192949\r\n\r\n##
Summary\r\n\r\nUpdates the \"add data\" page according to new
design\r\n\r\n<img width=\"1448\" alt=\"Screenshot 2024-10-01 at 12 36
15\"\r\nsrc=\"https://github.com/user-attachments/assets/1301a487-d3b9-4d6f-ad5d-f88d2cfc029d\">\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"28d6a22263ea1f60d9b17aacde7fa3517efd244e","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability"],"title":"[Observability
Onboarding] Update onboarding landing
page","number":194565,"url":"https://github.com/elastic/kibana/pull/194565","mergeCommit":{"message":"[Observability
Onboarding] Update onboarding landing page (#194565)\n\nResolves
https://github.com/elastic/observability-dev/issues/3775\r\nResolves
https://github.com/elastic/kibana/issues/192949\r\n\r\n##
Summary\r\n\r\nUpdates the \"add data\" page according to new
design\r\n\r\n<img width=\"1448\" alt=\"Screenshot 2024-10-01 at 12 36
15\"\r\nsrc=\"https://github.com/user-attachments/assets/1301a487-d3b9-4d6f-ad5d-f88d2cfc029d\">\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"28d6a22263ea1f60d9b17aacde7fa3517efd244e"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/194565","number":194565,"mergeCommit":{"message":"[Observability
Onboarding] Update onboarding landing page (#194565)\n\nResolves
https://github.com/elastic/observability-dev/issues/3775\r\nResolves
https://github.com/elastic/kibana/issues/192949\r\n\r\n##
Summary\r\n\r\nUpdates the \"add data\" page according to new
design\r\n\r\n<img width=\"1448\" alt=\"Screenshot 2024-10-01 at 12 36
15\"\r\nsrc=\"https://github.com/user-attachments/assets/1301a487-d3b9-4d6f-ad5d-f88d2cfc029d\">\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"28d6a22263ea1f60d9b17aacde7fa3517efd244e"}}]}]
BACKPORT-->

Co-authored-by: Thom Heymann <190132+thomheymann@users.noreply.github.com>
@kibanamachine kibanamachine added v8.16.0 and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mykolaharmash mykolaharmash mykolaharmash approved these changes

+1 more reviewer

@cee-chen cee-chen cee-chen left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes v8.16.0 v9.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Observability Onboarding] Add data page: First question description no clickable

7 participants

@thomheymann @obltmachine @mykolaharmash @kibana-ci @elasticmachine @kibanamachine @cee-chen