Skip to content

[ResponseOps][Flapping] Add Rule Specific Flapping Form to New Rule Form Page#194516

Merged
JiaweiWu merged 10 commits intoelastic:mainfrom
JiaweiWu:add-rule-specific-flapping-to-new-rule-form-page
Oct 10, 2024
Merged

[ResponseOps][Flapping] Add Rule Specific Flapping Form to New Rule Form Page#194516
JiaweiWu merged 10 commits intoelastic:mainfrom
JiaweiWu:add-rule-specific-flapping-to-new-rule-form-page

Conversation

@JiaweiWu
Copy link
Copy Markdown
Contributor

@JiaweiWu JiaweiWu commented Oct 1, 2024 •
edited by kibanamachine
Loading

Summary

Depends on: #194086
Designs: https://www.figma.com/design/eTr6WsKzhSLcQ24AlgrY8R/Flapping-per-Rule--%3E-%23294?node-id=5265-29867&node-type=frame&t=1VfgdlcjkSHmpbje-0

Adds the rule specific flapping form to the new rule form page.

To test:

  1. change IS_RULE_SPECIFIC_FLAPPING_ENABLED to true
  2. run yarn start --run-examples
  3. assert the new flapping UI exists by going to developer examples -> create/edit rule
Screenshot 2024-09-30 at 11 43 16 PM

Checklist

@JiaweiWu JiaweiWu added release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// v9.0.0 backport:prev-minor v8.16.0 labels Oct 1, 2024
@JiaweiWu JiaweiWu requested a review from a team as a code owner October 1, 2024 06:30
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Oct 1, 2024

Pinging @elastic/response-ops (Team:ResponseOps)

@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Oct 1, 2024 •
edited
Loading

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #2 / alert_form alert_form edit alert renders alert name
  • [job] [logs] Jest Tests #2 / alert_form alert_form edit alert renders alert name
  • [job] [logs] Jest Tests #2 / alert_form alert_form edit alert renders registered selected alert type
  • [job] [logs] Jest Tests #2 / alert_form alert_form edit alert renders registered selected alert type

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
triggersActionsUi 798 803 +5

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/alerting-types 219 241 +22

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
triggersActionsUi 1.6MB 1.6MB +4.4KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
triggersActionsUi 123.3KB 123.2KB -71.0B
Unknown metric groups

API count

id before after diff
@kbn/alerting-types 222 244 +22

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@JiaweiWu
Copy link
Copy Markdown
Contributor Author

JiaweiWu commented Oct 8, 2024

@elasticmachine merge upstream

ersin-erdal
ersin-erdal approved these changes Oct 8, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@ersin-erdal ersin-erdal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
I can see the new section in the for add/edit form

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Oct 9, 2024

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #49 / discover/esql discover esql view switch modal should not show switch modal when switching to a data view while a saved search is open

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
alerting 236 239 +3
cases 811 812 +1
observability 1060 1061 +1
securitySolution 5926 5927 +1
triggersActionsUi 799 805 +6
total +12

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/alerting-types 218 240 +22
alerting 841 848 +7
total +29

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
triggersActionsUi 1.6MB 1.6MB +2.6KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
alerting 25.2KB 25.5KB +254.0B
triggersActionsUi 123.3KB 123.2KB -71.0B
total +183.0B
Unknown metric groups

API count

id before after diff
@kbn/alerting-types 221 243 +22
alerting 873 880 +7
total +29

History

@JiaweiWu JiaweiWu merged commit 447617e into elastic:main Oct 10, 2024
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Oct 10, 2024

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11266094506

kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Oct 10, 2024
@JiaweiWu @kibanamachine @elasticmachine
[ResponseOps][Flapping] Add Rule Specific Flapping Form to New Rule F…
698e416 
…orm Page (elastic#194516)

## Summary

Depends on: elastic#194086
Designs:
https://www.figma.com/design/eTr6WsKzhSLcQ24AlgrY8R/Flapping-per-Rule--%3E-%23294?node-id=5265-29867&node-type=frame&t=1VfgdlcjkSHmpbje-0

Adds the rule specific flapping form to the new rule form page.

## To test:

1. change `IS_RULE_SPECIFIC_FLAPPING_ENABLED` to true
2. run `yarn start --run-examples`
3. assert the new flapping UI exists by going to developer examples ->
create/edit rule

<img width="1162" alt="Screenshot 2024-09-30 at 11 43 16 PM"
src="https://github.com/user-attachments/assets/a1275a49-f2ed-43ce-815b-5c0bd93770e5">

### Checklist
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
(cherry picked from commit 447617e)
@kibanamachine kibanamachine mentioned this pull request Oct 10, 2024
Merged
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Oct 10, 2024

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 10, 2024
@kibanamachine @JiaweiWu
[8.x] [ResponseOps][Flapping] Add Rule Specific Flapping Form to New …
6df1c38 
…Rule Form Page (#194516) (#195697)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[ResponseOps][Flapping] Add Rule Specific Flapping Form to New Rule
Form Page (#194516)](#194516)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Jiawei
Wu","email":"74562234+JiaweiWu@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-10-10T02:01:58Z","message":"[ResponseOps][Flapping]
Add Rule Specific Flapping Form to New Rule Form Page (#194516)\n\n##
Summary\r\n\r\nDepends on:
https://github.com/elastic/kibana/pull/194086\r\nDesigns:\r\nhttps://www.figma.com/design/eTr6WsKzhSLcQ24AlgrY8R/Flapping-per-Rule--%3E-%23294?node-id=5265-29867&node-type=frame&t=1VfgdlcjkSHmpbje-0\r\n\r\nAdds
the rule specific flapping form to the new rule form page. \r\n\r\n## To
test:\r\n\r\n1. change `IS_RULE_SPECIFIC_FLAPPING_ENABLED` to true
\r\n2. run `yarn start --run-examples`\r\n3. assert the new flapping UI
exists by going to developer examples ->\r\ncreate/edit rule\r\n\r\n<img
width=\"1162\" alt=\"Screenshot 2024-09-30 at 11 43
16 PM\"\r\nsrc=\"https://github.com/user-attachments/assets/a1275a49-f2ed-43ce-815b-5c0bd93770e5\">\r\n\r\n###
Checklist\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by:
Elastic Machine
<elasticmachine@users.noreply.github.com>","sha":"447617e2be18cbf8fdd495cb4b9570921b7fd467","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","v9.0.0","backport:prev-minor","v8.16.0"],"title":"[ResponseOps][Flapping]
Add Rule Specific Flapping Form to New Rule Form
Page","number":194516,"url":"https://github.com/elastic/kibana/pull/194516","mergeCommit":{"message":"[ResponseOps][Flapping]
Add Rule Specific Flapping Form to New Rule Form Page (#194516)\n\n##
Summary\r\n\r\nDepends on:
https://github.com/elastic/kibana/pull/194086\r\nDesigns:\r\nhttps://www.figma.com/design/eTr6WsKzhSLcQ24AlgrY8R/Flapping-per-Rule--%3E-%23294?node-id=5265-29867&node-type=frame&t=1VfgdlcjkSHmpbje-0\r\n\r\nAdds
the rule specific flapping form to the new rule form page. \r\n\r\n## To
test:\r\n\r\n1. change `IS_RULE_SPECIFIC_FLAPPING_ENABLED` to true
\r\n2. run `yarn start --run-examples`\r\n3. assert the new flapping UI
exists by going to developer examples ->\r\ncreate/edit rule\r\n\r\n<img
width=\"1162\" alt=\"Screenshot 2024-09-30 at 11 43
16 PM\"\r\nsrc=\"https://github.com/user-attachments/assets/a1275a49-f2ed-43ce-815b-5c0bd93770e5\">\r\n\r\n###
Checklist\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by:
Elastic Machine
<elasticmachine@users.noreply.github.com>","sha":"447617e2be18cbf8fdd495cb4b9570921b7fd467"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/194516","number":194516,"mergeCommit":{"message":"[ResponseOps][Flapping]
Add Rule Specific Flapping Form to New Rule Form Page (#194516)\n\n##
Summary\r\n\r\nDepends on:
https://github.com/elastic/kibana/pull/194086\r\nDesigns:\r\nhttps://www.figma.com/design/eTr6WsKzhSLcQ24AlgrY8R/Flapping-per-Rule--%3E-%23294?node-id=5265-29867&node-type=frame&t=1VfgdlcjkSHmpbje-0\r\n\r\nAdds
the rule specific flapping form to the new rule form page. \r\n\r\n## To
test:\r\n\r\n1. change `IS_RULE_SPECIFIC_FLAPPING_ENABLED` to true
\r\n2. run `yarn start --run-examples`\r\n3. assert the new flapping UI
exists by going to developer examples ->\r\ncreate/edit rule\r\n\r\n<img
width=\"1162\" alt=\"Screenshot 2024-09-30 at 11 43
16 PM\"\r\nsrc=\"https://github.com/user-attachments/assets/a1275a49-f2ed-43ce-815b-5c0bd93770e5\">\r\n\r\n###
Checklist\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by:
Elastic Machine
<elasticmachine@users.noreply.github.com>","sha":"447617e2be18cbf8fdd495cb4b9570921b7fd467"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Jiawei Wu <74562234+JiaweiWu@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ersin-erdal ersin-erdal ersin-erdal approved these changes

@Zacqary Zacqary Awaiting requested review from Zacqary

Assignees

No one assigned

Labels

release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// v8.16.0 v9.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@JiaweiWu @elasticmachine @kibana-ci @kibanamachine @ersin-erdal