Skip to content

[8.15] [Security Solution] [Security Assistant] Fixes an unable to load page error in the Security assistant (#194488) #194506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kibanamachine merged 1 commit into from
Oct 1, 2024
Merged

[8.15] [Security Solution] [Security Assistant] Fixes an unable to load page error in the Security assistant (#194488) #194506

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions x-pack/packages/kbn-elastic-assistant-common/impl/data_anonymization/helpers/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,30 @@ describe('helpers', () => {
expect(result).toEqual(messageContent);
});

it('returns the original messageContent if replacements is null', () => {
const messageContent =
'User {{ user.name 3541b730-1dce-4937-b63f-0d618ea1cc5f }} added a member to the Administrators group on host {{ host.name b222e892-431e-4e4f-9295-2ba92ef9d12d }}';

const result = replaceAnonymizedValuesWithOriginalValues({
messageContent,
replacements: null, // <-- null
});

expect(result).toEqual(messageContent);
});

it('returns the original messageContent if replacements is undefined', () => {
const messageContent =
'User {{ user.name 3541b730-1dce-4937-b63f-0d618ea1cc5f }} added a member to the Administrators group on host {{ host.name b222e892-431e-4e4f-9295-2ba92ef9d12d }}';

const result = replaceAnonymizedValuesWithOriginalValues({
messageContent,
replacements: undefined, // <-- undefined
});

expect(result).toEqual(messageContent);
});

it('replaces multiple occurrences of the same replacement key', () => {
const messageContent =
'User {{ user.name 3541b730-1dce-4937-b63f-0d618ea1cc5f }} added a member to the Administrators group on host {{ host.name b222e892-431e-4e4f-9295-2ba92ef9d12d }}, which is unusual because {{ user.name 3541b730-1dce-4937-b63f-0d618ea1cc5f }} is not a member of the Administrators group.';
Expand Down
12 changes: 7 additions & 5 deletions x-pack/packages/kbn-elastic-assistant-common/impl/data_anonymization/helpers/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,13 +40,15 @@ export const replaceAnonymizedValuesWithOriginalValues = ({
replacements,
}: {
messageContent: string;
replacements: Replacements;
replacements: Replacements | null | undefined;
}): string =>
Object.keys(replacements).reduce((acc, key) => {
const value = replacements[key];
replacements != null
? Object.keys(replacements).reduce((acc, key) => {
const value = replacements[key];

return acc.replaceAll(key, value);
}, messageContent);
return acc.replaceAll(key, value);
}, messageContent)
: messageContent;

export const replaceOriginalValuesWithUuidValues = ({
messageContent,
Expand Down