Skip to content

[8.x] Upgrade EUI to v95.12.0 (#193805)#194500

Merged
kibanamachine merged 1 commit intoelastic:8.xfrom
kibanamachine:backport/8.x/pr-193805
Oct 1, 2024
Merged

[8.x] Upgrade EUI to v95.12.0 (#193805)#194500
kibanamachine merged 1 commit intoelastic:8.xfrom
kibanamachine:backport/8.x/pr-193805

Conversation

@kibanamachine
Copy link
Contributor

@kibanamachine kibanamachine commented Sep 30, 2024

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

@cee-chen
Upgrade EUI to v95.12.0 (elastic#193805)
ab674ac 
`v95.11.0`⏩`v95.12.0-backport.0`

> [!note]
> A few fun highlights from this release:
> - Content within `EuiDataGrid`, `EuiBasicTable`, and
`EuiInMemoryTable`, when manually selected/highlighted by users, should
now more cleanly copy and paste into various spreadsheet apps
> - `EuiProvider` will now detect the user's system-level dark or light
mode and default to that if no `colorMode` prop is passed manually

_[Questions? Please see our Kibana upgrade
FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)_

---

## [`v95.12.0`](https://github.com/elastic/eui/releases/v95.12.0)

- Enhanced `EuiDataGrid` and `EuiBasic/InMemoryTable` to clean content
newlines/tabs when users copy and paste from their tabular data
([elastic#8019](elastic/eui#8019))
- Updated `EuiResizableButton` with a new `accountForScrollbars` prop
([elastic#8021](elastic/eui#8021))
- Updated `EuiProvider` to inherit from the user's OS/system light/dark
mode setting if a `colorMode` prop has not been passed
([elastic#8026](elastic/eui#8026))

**Bug fixes**

- Fixed `EuiDatePicker`'s `onClear` button to not appear when the input
is `disabled` ([elastic#8020](elastic/eui#8020))
- Fixed several `EuiDataGrid` row height bugs:
([elastic#8025](elastic/eui#8025))
- Fixed row heights not recalculating when
`rowHeightOptions.lineHeight`, `gridStyles.fontSize`, or
`gridStyles.cellPadding` changed
- Fixed incorrect height calculations for `rowHeightOptions.rowHeights`
with `lineCount`s
- Fixed control column content to align better with multi-line row
heights, as well as custom line-heights
##
[`v95.12.0-backport.0`](https://github.com/elastic/eui/releases/v95.12.0-backport.0)

**This is a backport release only intended for use by Kibana.**

**Bug fixes**

- Fixed `EuiProvider`'s system color mode detection causing errors
during server-side rendering
([elastic#8040](elastic/eui#8040))
- Fixed an `EuiDataGrid` rendering bug that was causing bouncing
scrollbar issues ([elastic#8041](elastic/eui#8041))

(cherry picked from commit 8a89c85)
@kibanamachine kibanamachine added the backport This PR is a backport of another PR label Sep 30, 2024
@kibanamachine kibanamachine enabled auto-merge (squash) September 30, 2024 23:30
@kibanamachine kibanamachine mentioned this pull request Sep 30, 2024
Merged
@kibana-ci
Copy link

kibana-ci commented Oct 1, 2024

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
cloudSecurityPosture 652 651 -1
controls 353 355 +2
discover 992 991 -1
esqlDataGrid 363 362 -1
infra 1502 1504 +2
kubernetesSecurity 200 202 +2
lens 1461 1460 -1
logsExplorer 562 561 -1
maps 1237 1239 +2
securitySolution 5929 5928 -1
slo 846 845 -1
visTypeVega 270 272 +2
total +3

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/unified-data-table 110 108 -2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cloudSecurityPosture 507.2KB 506.9KB -285.0B
controls 456.1KB 458.9KB +2.8KB
discover 820.3KB 820.1KB -270.0B
esqlDataGrid 154.3KB 154.1KB -270.0B
infra 1.6MB 1.6MB +2.8KB
kubernetesSecurity 212.5KB 215.3KB +2.8KB
maps 3.0MB 3.0MB +2.8KB
securitySolution 20.5MB 20.5MB -1.4KB
slo 854.6KB 854.3KB -291.0B
visTypeVega 1.8MB 1.8MB +2.8KB
total +11.5KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
@kbn/unified-data-table 2 1 -1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kbnUiSharedDeps-npmDll 6.2MB 6.2MB +5.8KB
Unknown metric groups

API count

id before after diff
@kbn/unified-data-table 185 183 -2

ESLint disabled line counts

id before after diff
@kbn/test 14 8 -6

Total ESLint disabled count

id before after diff
@kbn/test 14 8 -6

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @cee-chen

@kibanamachine kibanamachine merged commit 20ee61b into elastic:8.x Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

@cee-chen cee-chen

Labels

backport This PR is a backport of another PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kibanamachine @kibana-ci @cee-chen