Set useEcs to true in SLO burn rate rule#194322
Merged
maryam-saeidi merged 7 commits intoelastic:mainfrom Oct 1, 2024
Merged
Conversation
maryam-saeidi
added
release_note:skip
botelastic
Bot
added
ci:project-deploy-observability
Contributor
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
ymao1
approved these changes
Sep 30, 2024
Contributor
ymao1
left a comment
ymao1
left a comment
There was a problem hiding this comment.
LGTM. Verified could upgrade from main with no issues.
maryam-saeidi
commented
Sep 30, 2024
| } | ||
| ); | ||
| expect(geoPointFieldStats.count).to.be(47); | ||
| expect(geoPointFieldStats.count).to.be(55); |
Member
Author
There was a problem hiding this comment.
I saw a similar change for this value here, @doakalexi can you please help me understand why this change happened when I updated the SLO burn rate rule mapping?
💛 Build succeeded, but was flaky
Failed CI StepsTest FailuresMetrics [docs]
History
To update your PR or re-run it, just comment with: |
nreese
approved these changes
Oct 1, 2024
Contributor
nreese
left a comment
nreese
left a comment
There was a problem hiding this comment.
kibana-gis changes LGTM
code review only
Contributor
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11126440739 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 1, 2024
## Summary This PR sets useEcs to true in the SLO burn rate rule. (more info [here](https://docs.google.com/document/d/1mhWcMR3aIp3z4SmPywpW89RG4hHiBAjYCQIQBDUYNj0/edit?usp=sharing)) (cherry picked from commit 67f3043)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 1, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [Set useEcs to true in SLO burn rate rule (#194322)](#194322) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Maryam Saeidi","email":"maryam.saeidi@elastic.co"},"sourceCommit":{"committedDate":"2024-10-01T13:32:03Z","message":"Set useEcs to true in SLO burn rate rule (#194322)\n\n## Summary\r\n\r\nThis PR sets useEcs to true in the SLO burn rate rule. (more info\r\n[here](https://docs.google.com/document/d/1mhWcMR3aIp3z4SmPywpW89RG4hHiBAjYCQIQBDUYNj0/edit?usp=sharing))","sha":"67f30433fdf1dea1793af3da8519a66a9dc4bd34","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-management"],"title":"Set useEcs to true in SLO burn rate rule","number":194322,"url":"https://github.com/elastic/kibana/pull/194322","mergeCommit":{"message":"Set useEcs to true in SLO burn rate rule (#194322)\n\n## Summary\r\n\r\nThis PR sets useEcs to true in the SLO burn rate rule. (more info\r\n[here](https://docs.google.com/document/d/1mhWcMR3aIp3z4SmPywpW89RG4hHiBAjYCQIQBDUYNj0/edit?usp=sharing))","sha":"67f30433fdf1dea1793af3da8519a66a9dc4bd34"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/194322","number":194322,"mergeCommit":{"message":"Set useEcs to true in SLO burn rate rule (#194322)\n\n## Summary\r\n\r\nThis PR sets useEcs to true in the SLO burn rate rule. (more info\r\n[here](https://docs.google.com/document/d/1mhWcMR3aIp3z4SmPywpW89RG4hHiBAjYCQIQBDUYNj0/edit?usp=sharing))","sha":"67f30433fdf1dea1793af3da8519a66a9dc4bd34"}}]}] BACKPORT--> Co-authored-by: Maryam Saeidi <maryam.saeidi@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR sets useEcs to true in the SLO burn rate rule. (more info here)