[ML] Fix file upload when pipeline is used#194273
Merged
jgowdyelastic merged 6 commits intoelastic:mainfrom Sep 27, 2024
Merged
[ML] Fix file upload when pipeline is used#194273jgowdyelastic merged 6 commits intoelastic:mainfrom
jgowdyelastic merged 6 commits intoelastic:mainfrom
Conversation
jgowdyelastic
added
:ml
release_note:skip
Contributor
|
Pinging @elastic/ml-ui (:ml) |
peteharverson
approved these changes
Sep 27, 2024
Contributor
peteharverson
left a comment
peteharverson
left a comment
There was a problem hiding this comment.
Tested and confirmed the import works when a pipeline is (or isn't) used.
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
History
To update your PR or re-run it, just comment with: |
Contributor
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11075110939 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 27, 2024
Fixes bug introduced in elastic#193744 If a file is uploaded with an ingest pipeline, the pipeline is created, but not used when uploading the data. Adds tests to check that the data exists in the index and the expected fields exist and are populated. (cherry picked from commit 6fd1913)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Sep 27, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [[ML] Fix file upload when pipline is used (#194273)](#194273) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"James Gowdy","email":"jgowdy@elastic.co"},"sourceCommit":{"committedDate":"2024-09-27T17:31:47Z","message":"[ML] Fix file upload when pipline is used (#194273)\n\nFixes bug introduced in https://github.com/elastic/kibana/pull/193744\r\n\r\nIf a file is uploaded with an ingest pipeline, the pipeline is created,\r\nbut not used when uploading the data.\r\n\r\nAdds tests to check that the data exists in the index and the expected\r\nfields exist and are populated.","sha":"6fd19137fe1cb0293ce84f3bba8f8ae7fedd98c9","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":[":ml","release_note:skip","Feature:File and Index Data Viz","Feature:File Upload","v9.0.0","v8.16.0","backport:version"],"title":"[ML] Fix file upload when pipline is used","number":194273,"url":"https://github.com/elastic/kibana/pull/194273","mergeCommit":{"message":"[ML] Fix file upload when pipline is used (#194273)\n\nFixes bug introduced in https://github.com/elastic/kibana/pull/193744\r\n\r\nIf a file is uploaded with an ingest pipeline, the pipeline is created,\r\nbut not used when uploading the data.\r\n\r\nAdds tests to check that the data exists in the index and the expected\r\nfields exist and are populated.","sha":"6fd19137fe1cb0293ce84f3bba8f8ae7fedd98c9"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/194273","number":194273,"mergeCommit":{"message":"[ML] Fix file upload when pipline is used (#194273)\n\nFixes bug introduced in https://github.com/elastic/kibana/pull/193744\r\n\r\nIf a file is uploaded with an ingest pipeline, the pipeline is created,\r\nbut not used when uploading the data.\r\n\r\nAdds tests to check that the data exists in the index and the expected\r\nfields exist and are populated.","sha":"6fd19137fe1cb0293ce84f3bba8f8ae7fedd98c9"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: James Gowdy <jgowdy@elastic.co>
walterra
changed the title
23 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes bug introduced in #193744
If a file is uploaded with an ingest pipeline, the pipeline is created, but not used when uploading the data.
Adds tests to check that the data exists in the index and the expected fields exist and are populated.