[Automatic Import] Fix deploy error after editing the pipeline#194203
Merged
bhapas merged 1 commit intoelastic:mainfrom Sep 26, 2024
Merged
[Automatic Import] Fix deploy error after editing the pipeline#194203bhapas merged 1 commit intoelastic:mainfrom
bhapas merged 1 commit intoelastic:mainfrom
Conversation
bhapas
added
bug
Contributor
|
Pinging @elastic/security-scalability (Team:Security-Scalability) |
bhapas
force-pushed
the
automatic_import_fix_edit_deploy
branch
from
ff96ad3 to
e8c3282
Compare
kgeller
approved these changes
Sep 26, 2024
Contributor
kgeller
left a comment
kgeller
left a comment
There was a problem hiding this comment.
Could we also add a unit test for this? So we don't inadvertently break it again in the future
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
To update your PR or re-run it, just comment with: cc @bhapas |
Contributor
|
Starting backport for target branches: 8.15, 8.x https://github.com/elastic/kibana/actions/runs/11058692252 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 26, 2024
…ic#194203) ## Release Note Fixes a bug that is causing the deploy step to fail after a pipeline edit/save. ## Summary elastic#190407 introduced a bug that deployment fails when a pipeline is edited and saved in the review step. The issue is that after the edit pipeline flow is executed the review step's result is overridden and `samplesFormat` is removed which if not present [the `useEffect` in Deploy step](https://github.com/elastic/kibana/blob/main/x-pack/plugins/integration_assistant/public/components/create_integration/create_integration_assistant/steps/deploy_step/use_deploy_integration.ts#L41) fails. This PR fixes the issue by saving the `samplesFormat` that is present in the original result before the edit pipeline flow is executed there by having samplesFormat in the result. (cherry picked from commit 6366dc3)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 26, 2024
…ic#194203) ## Release Note Fixes a bug that is causing the deploy step to fail after a pipeline edit/save. ## Summary elastic#190407 introduced a bug that deployment fails when a pipeline is edited and saved in the review step. The issue is that after the edit pipeline flow is executed the review step's result is overridden and `samplesFormat` is removed which if not present [the `useEffect` in Deploy step](https://github.com/elastic/kibana/blob/main/x-pack/plugins/integration_assistant/public/components/create_integration/create_integration_assistant/steps/deploy_step/use_deploy_integration.ts#L41) fails. This PR fixes the issue by saving the `samplesFormat` that is present in the original result before the edit pipeline flow is executed there by having samplesFormat in the result. (cherry picked from commit 6366dc3)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Sep 26, 2024
…194203) (#194217) # Backport This will backport the following commits from `main` to `8.x`: - [[Automatic Import] Fix deploy error after editing the pipeline (#194203)](#194203) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Bharat Pasupula","email":"123897612+bhapas@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-09-26T19:09:38Z","message":"[Automatic Import] Fix deploy error after editing the pipeline (#194203)\n\n## Release Note\r\n\r\nFixes a bug that is causing the deploy step to fail after a pipeline\r\nedit/save.\r\n\r\n## Summary\r\n\r\n#190407 introduced a bug that deployment fails when a pipeline is edited\r\nand saved in the review step.\r\n\r\nThe issue is that after the edit pipeline flow is executed the review\r\nstep's result is overridden and `samplesFormat` is removed which if not\r\npresent [the `useEffect` in Deploy\r\nstep](https://github.com/elastic/kibana/blob/main/x-pack/plugins/integration_assistant/public/components/create_integration/create_integration_assistant/steps/deploy_step/use_deploy_integration.ts#L41)\r\nfails.\r\n\r\nThis PR fixes the issue by saving the `samplesFormat` that is present in\r\nthe original result before the edit pipeline flow is executed there by\r\nhaving samplesFormat in the result.","sha":"6366dc344a239a24c65f8c6c829a43353e0243d6","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","v9.0.0","backport:prev-major","Team:Security-Scalability","Feature:AutomaticImport"],"title":"[Automatic Import] Fix deploy error after editing the pipeline","number":194203,"url":"https://github.com/elastic/kibana/pull/194203","mergeCommit":{"message":"[Automatic Import] Fix deploy error after editing the pipeline (#194203)\n\n## Release Note\r\n\r\nFixes a bug that is causing the deploy step to fail after a pipeline\r\nedit/save.\r\n\r\n## Summary\r\n\r\n#190407 introduced a bug that deployment fails when a pipeline is edited\r\nand saved in the review step.\r\n\r\nThe issue is that after the edit pipeline flow is executed the review\r\nstep's result is overridden and `samplesFormat` is removed which if not\r\npresent [the `useEffect` in Deploy\r\nstep](https://github.com/elastic/kibana/blob/main/x-pack/plugins/integration_assistant/public/components/create_integration/create_integration_assistant/steps/deploy_step/use_deploy_integration.ts#L41)\r\nfails.\r\n\r\nThis PR fixes the issue by saving the `samplesFormat` that is present in\r\nthe original result before the edit pipeline flow is executed there by\r\nhaving samplesFormat in the result.","sha":"6366dc344a239a24c65f8c6c829a43353e0243d6"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/194203","number":194203,"mergeCommit":{"message":"[Automatic Import] Fix deploy error after editing the pipeline (#194203)\n\n## Release Note\r\n\r\nFixes a bug that is causing the deploy step to fail after a pipeline\r\nedit/save.\r\n\r\n## Summary\r\n\r\n#190407 introduced a bug that deployment fails when a pipeline is edited\r\nand saved in the review step.\r\n\r\nThe issue is that after the edit pipeline flow is executed the review\r\nstep's result is overridden and `samplesFormat` is removed which if not\r\npresent [the `useEffect` in Deploy\r\nstep](https://github.com/elastic/kibana/blob/main/x-pack/plugins/integration_assistant/public/components/create_integration/create_integration_assistant/steps/deploy_step/use_deploy_integration.ts#L41)\r\nfails.\r\n\r\nThis PR fixes the issue by saving the `samplesFormat` that is present in\r\nthe original result before the edit pipeline flow is executed there by\r\nhaving samplesFormat in the result.","sha":"6366dc344a239a24c65f8c6c829a43353e0243d6"}}]}] BACKPORT--> Co-authored-by: Bharat Pasupula <123897612+bhapas@users.noreply.github.com>
kibanamachine
added a commit
that referenced
this pull request
Sep 26, 2024
…#194203) (#194216) # Backport This will backport the following commits from `main` to `8.15`: - [[Automatic Import] Fix deploy error after editing the pipeline (#194203)](#194203) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Bharat Pasupula","email":"123897612+bhapas@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-09-26T19:09:38Z","message":"[Automatic Import] Fix deploy error after editing the pipeline (#194203)\n\n## Release Note\r\n\r\nFixes a bug that is causing the deploy step to fail after a pipeline\r\nedit/save.\r\n\r\n## Summary\r\n\r\n#190407 introduced a bug that deployment fails when a pipeline is edited\r\nand saved in the review step.\r\n\r\nThe issue is that after the edit pipeline flow is executed the review\r\nstep's result is overridden and `samplesFormat` is removed which if not\r\npresent [the `useEffect` in Deploy\r\nstep](https://github.com/elastic/kibana/blob/main/x-pack/plugins/integration_assistant/public/components/create_integration/create_integration_assistant/steps/deploy_step/use_deploy_integration.ts#L41)\r\nfails.\r\n\r\nThis PR fixes the issue by saving the `samplesFormat` that is present in\r\nthe original result before the edit pipeline flow is executed there by\r\nhaving samplesFormat in the result.","sha":"6366dc344a239a24c65f8c6c829a43353e0243d6","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","v9.0.0","backport:prev-major","Team:Security-Scalability","Feature:AutomaticImport"],"title":"[Automatic Import] Fix deploy error after editing the pipeline","number":194203,"url":"https://github.com/elastic/kibana/pull/194203","mergeCommit":{"message":"[Automatic Import] Fix deploy error after editing the pipeline (#194203)\n\n## Release Note\r\n\r\nFixes a bug that is causing the deploy step to fail after a pipeline\r\nedit/save.\r\n\r\n## Summary\r\n\r\n#190407 introduced a bug that deployment fails when a pipeline is edited\r\nand saved in the review step.\r\n\r\nThe issue is that after the edit pipeline flow is executed the review\r\nstep's result is overridden and `samplesFormat` is removed which if not\r\npresent [the `useEffect` in Deploy\r\nstep](https://github.com/elastic/kibana/blob/main/x-pack/plugins/integration_assistant/public/components/create_integration/create_integration_assistant/steps/deploy_step/use_deploy_integration.ts#L41)\r\nfails.\r\n\r\nThis PR fixes the issue by saving the `samplesFormat` that is present in\r\nthe original result before the edit pipeline flow is executed there by\r\nhaving samplesFormat in the result.","sha":"6366dc344a239a24c65f8c6c829a43353e0243d6"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/194203","number":194203,"mergeCommit":{"message":"[Automatic Import] Fix deploy error after editing the pipeline (#194203)\n\n## Release Note\r\n\r\nFixes a bug that is causing the deploy step to fail after a pipeline\r\nedit/save.\r\n\r\n## Summary\r\n\r\n#190407 introduced a bug that deployment fails when a pipeline is edited\r\nand saved in the review step.\r\n\r\nThe issue is that after the edit pipeline flow is executed the review\r\nstep's result is overridden and `samplesFormat` is removed which if not\r\npresent [the `useEffect` in Deploy\r\nstep](https://github.com/elastic/kibana/blob/main/x-pack/plugins/integration_assistant/public/components/create_integration/create_integration_assistant/steps/deploy_step/use_deploy_integration.ts#L41)\r\nfails.\r\n\r\nThis PR fixes the issue by saving the `samplesFormat` that is present in\r\nthe original result before the edit pipeline flow is executed there by\r\nhaving samplesFormat in the result.","sha":"6366dc344a239a24c65f8c6c829a43353e0243d6"}}]}] BACKPORT--> Co-authored-by: Bharat Pasupula <123897612+bhapas@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release Note
Fixes a bug that is causing the deploy step to fail after a pipeline edit/save.
Summary
#190407 introduced a bug that deployment fails when a pipeline is edited and saved in the review step.
The issue is that after the edit pipeline flow is executed the review step's result is overridden and
samplesFormatis removed which if not present theuseEffectin Deploy step fails.This PR fixes the issue by saving the
samplesFormatthat is present in the original result before the edit pipeline flow is executed there by having samplesFormat in the result.