[Automatic Import] Refactor useEffect to reduce complexity#194150
Merged
bhapas merged 4 commits intoelastic:mainfrom Sep 26, 2024
Merged
[Automatic Import] Refactor useEffect to reduce complexity#194150bhapas merged 4 commits intoelastic:mainfrom
bhapas merged 4 commits intoelastic:mainfrom
Conversation
bhapas
changed the title
bhapas
added
enhancement
Contributor
|
Pinging @elastic/security-scalability (Team:Security-Scalability) |
bhapas
added
release_note:skip
semd
reviewed
Sep 26, 2024
...ts/create_integration/create_integration_assistant/steps/data_stream_step/use_generation.tsx
Outdated
Show resolved
Hide resolved
bhapas
commented
Sep 26, 2024
...ts/create_integration/create_integration_assistant/steps/data_stream_step/use_generation.tsx
Outdated
Show resolved
Hide resolved
semd
reviewed
Sep 26, 2024
...ts/create_integration/create_integration_assistant/steps/data_stream_step/use_generation.tsx
Outdated
Show resolved
Hide resolved
semd
approved these changes
Sep 26, 2024
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Module Count
Async chunks
To update your PR or re-run it, just comment with: cc @bhapas |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 26, 2024
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
2 tasks
kibanamachine
added a commit
that referenced
this pull request
Sep 26, 2024
…4150) (#194194) # Backport This will backport the following commits from `main` to `8.x`: - [[Automatic Import] Refactor useEffect to reduce complexity (#194150)](#194150) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Bharat Pasupula","email":"123897612+bhapas@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-09-26T16:50:28Z","message":"[Automatic Import] Refactor useEffect to reduce complexity (#194150)","sha":"bcdb0d8ede90a99317bddd99cc122dc98107d1a7","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","Team:Security-Scalability","Feature:AutomaticImport"],"title":"[Automatic Import] Refactor useEffect to reduce complexity","number":194150,"url":"https://github.com/elastic/kibana/pull/194150","mergeCommit":{"message":"[Automatic Import] Refactor useEffect to reduce complexity (#194150)","sha":"bcdb0d8ede90a99317bddd99cc122dc98107d1a7"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/194150","number":194150,"mergeCommit":{"message":"[Automatic Import] Refactor useEffect to reduce complexity (#194150)","sha":"bcdb0d8ede90a99317bddd99cc122dc98107d1a7"}}]}] BACKPORT--> Co-authored-by: Bharat Pasupula <123897612+bhapas@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes - #193947
useGenerationhook into own fileuse_generation.tsx