Skip to content

[Entity Analytics] Integration tests: Kibana spaces support in Entity Store #194130

Merged
tiansivive merged 10 commits intoelastic:mainfrom
tiansivive:ea-entity-engine-spaces-tests
Oct 8, 2024
Merged

[Entity Analytics] Integration tests: Kibana spaces support in Entity Store #194130
tiansivive merged 10 commits intoelastic:mainfrom
tiansivive:ea-entity-engine-spaces-tests

Conversation

@tiansivive
Copy link
Copy Markdown
Contributor

@tiansivive tiansivive commented Sep 26, 2024

Summary

This PR adds integration tests for Kibana spaces support in the Entity Store

@tiansivive tiansivive added backport:prev-minor release_note:skip Skip the PR/issue when compiling release notes v8.16.0 Team:Entity Analytics Security Entity Analytics Team labels Sep 26, 2024
@tiansivive tiansivive force-pushed the ea-entity-engine-spaces-tests branch from f361cdd to 5367f29 Compare September 27, 2024 09:13
@tiansivive tiansivive added this to the 8.16 milestone Sep 27, 2024
@tiansivive tiansivive marked this pull request as ready for review September 27, 2024 09:16
@tiansivive tiansivive requested review from a team as code owners September 27, 2024 09:16
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/security-entity-analytics (Team:Entity Analytics)

@tiansivive tiansivive changed the title Ea entity engine spaces tests [Entity Analytics] Integration tests: Kibana spaces support in Entity Store Sep 27, 2024
@tiansivive
Copy link
Copy Markdown
Contributor Author

@elasticmachine merge upstream

@tiansivive tiansivive enabled auto-merge (squash) October 4, 2024 14:05
@kibana-ci
Copy link
Copy Markdown

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #59 / Reporting Functional Tests with Security enabled Access to Management > Reporting Download report user can access download link for export type that is no longer supported

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Copy Markdown
Contributor

@CAWilson94 CAWilson94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - just left one question.


"entity_analytics:server:serverless": "npm run initialize-server:ea:trial_complete risk_engine serverless",
"entity_analytics:runner:serverless": "npm run run-tests:ea:trial_complete risk_engine serverless serverlessEnv",
"entity_analytics:runner:serverless": "npm run run-tests:ea:trial_complete risk_engine serverless serverlessEnv --",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the -- at the end a leftover or are we good to keep it version control for general use?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i guess we're keeping it 😅

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am in full support ^^

@tiansivive tiansivive merged commit ca1d375 into elastic:main Oct 8, 2024
@kibanamachine
Copy link
Copy Markdown
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11236479061

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 8, 2024
… Store (elastic#194130)

### Summary

This PR adds integration tests for Kibana spaces support in the Entity
Store

---------

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
(cherry picked from commit ca1d375)
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 8, 2024
…Entity Store (#194130) (#195413)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Entity Analytics] Integration tests: Kibana spaces support in Entity
Store (#194130)](#194130)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Tiago Vila
Verde","email":"tiago.vilaverde@elastic.co"},"sourceCommit":{"committedDate":"2024-10-08T13:27:09Z","message":"[Entity
Analytics] Integration tests: Kibana spaces support in Entity Store
(#194130)\n\n### Summary\r\n\r\nThis PR adds integration tests for
Kibana spaces support in the
Entity\r\nStore\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine
<elasticmachine@users.noreply.github.com>","sha":"ca1d375348ef17721372612b408d9c31ac5d2494","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","Team:Entity
Analytics","v8.16.0"],"title":"[Entity Analytics] Integration tests:
Kibana spaces support in Entity Store
","number":194130,"url":"https://github.com/elastic/kibana/pull/194130","mergeCommit":{"message":"[Entity
Analytics] Integration tests: Kibana spaces support in Entity Store
(#194130)\n\n### Summary\r\n\r\nThis PR adds integration tests for
Kibana spaces support in the
Entity\r\nStore\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine
<elasticmachine@users.noreply.github.com>","sha":"ca1d375348ef17721372612b408d9c31ac5d2494"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/194130","number":194130,"mergeCommit":{"message":"[Entity
Analytics] Integration tests: Kibana spaces support in Entity Store
(#194130)\n\n### Summary\r\n\r\nThis PR adds integration tests for
Kibana spaces support in the
Entity\r\nStore\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine
<elasticmachine@users.noreply.github.com>","sha":"ca1d375348ef17721372612b408d9c31ac5d2494"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Tiago Vila Verde <tiago.vilaverde@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release_note:skip Skip the PR/issue when compiling release notes Team:Entity Analytics Security Entity Analytics Team v8.16.0 v9.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants