[ES|QL] Present ES|QL as an equal to data views on the "no data views" screen#194077
Merged
tsullivan merged 31 commits intoelastic:mainfrom Oct 9, 2024
Merged
Conversation
tsullivan
force-pushed
the
no-data-views/esql-equal-to-data-views
branch
12 times, most recently
from
8b73c7a to
87cba2a
Compare
…romptKibanaProvider
tsullivan
force-pushed
the
no-data-views/esql-equal-to-data-views
branch
from
87cba2a to
db7cbae
Compare
tsullivan
commented
Oct 4, 2024
| jest.resetAllMocks(); | ||
| }); | ||
|
|
||
| it('renders correctly', async () => { |
Member
Author
There was a problem hiding this comment.
Previously, this test was only rendering the "loading" state of the component. I moved the existing tests into a describe block for this.
….component.tsx Co-authored-by: Andrea Del Rio <delrio.andre@gmail.com>
Member
Author
|
Thanks @andreadelrio I have added the disabled button that includes a tooltip for readonly users. I chose to position the tooltip to the right. Let me know if you'd prefer it to be positioned differently. 
|
Dosant
approved these changes
Oct 8, 2024
Member
@andreadelrio I'd either use the period for both sentences here or remove it |
Member
Could also remove the sub-text and just have one main CTA "How do you want to explore your Elasticsearch data?" |
Member
Author
|
Thanks @leemthompo 
|
andreadelrio
approved these changes
Oct 8, 2024
Contributor
andreadelrio
left a comment
andreadelrio
left a comment
There was a problem hiding this comment.
Design changes LGTM. Great job @tsullivan !
jughosta
approved these changes
Oct 9, 2024
Contributor
jughosta
left a comment
jughosta
left a comment
There was a problem hiding this comment.
Data Discovery changes LGTM 👍
Left some minor suggestions.
Comment on lines
+43
to
+46
| public async expectEsqlStatement(statement: string) { | ||
| const codeEditor = await this.testSubjects.find('kibanaCodeEditor'); | ||
| expect(await codeEditor.getAttribute('innerText')).to.contain(statement); | ||
| } |
Contributor
There was a problem hiding this comment.
There is also esql service for tests. Maybe it could be moved to it.
|
|
||
| /** Ensures that navigation to discover has completed */ | ||
| public async expectOnDiscover() { | ||
| await this.testSubjects.existOrFail('switch-to-dataviews'); // "Switch to Classic" app menu button |
Contributor
There was a problem hiding this comment.
In data view mode this button will not be present.
| /** | ||
| * A presentational component that is shown in cases when there are no data views created yet. | ||
| */ | ||
| export const NoDataViewsPrompt = ({ |
Contributor
There was a problem hiding this comment.
Would be great to add some padding for mobile view on Discover:
Contributor
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11263551346 |
Contributor
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Any counts in public APIs
Async chunks
Unknown metric groupsAPI count
async chunk count
miscellaneous assets size
History
|
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 9, 2024
…" screen (elastic#194077) ## Summary Resolves elastic#176291 ### Screenshots #### Discover/Dashboard/Visualize <img width="1517" alt="image" src="https://github.com/user-attachments/assets/c8fb4faf-8d2d-4043-a757-6f092d1fceb3"> #### Stack Management > Data view <img width="1519" alt="image" src="https://github.com/user-attachments/assets/bb3f28bd-0ce9-4c49-ace1-1be875e17ba3"> #### If User does not have privilege to create a Data View <img width="1336" alt="image" src="https://github.com/user-attachments/assets/bb3f4cbc-8213-41c0-bf09-bd47a9d264e4"> ### Checklist Delete any items that are not applicable to this PR. - [x] Use a new SVG resource for the ES|QL illustration - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [x] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [x] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Liam Thompson <32779855+leemthompo@users.noreply.github.com> Co-authored-by: Andrea Del Rio <delrio.andre@gmail.com> (cherry picked from commit 56e1e68)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 9, 2024
… data views" screen (#194077) (#195684) # Backport This will backport the following commits from `main` to `8.x`: - [[ES|QL] Present ES|QL as an equal to data views on the "no data views" screen (#194077)](#194077) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Tim Sullivan","email":"tsullivan@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-10-09T21:44:30Z","message":"[ES|QL] Present ES|QL as an equal to data views on the \"no data views\" screen (#194077)\n\n## Summary\r\n\r\nResolves https://github.com/elastic/kibana/issues/176291\r\n\r\n### Screenshots\r\n\r\n#### Discover/Dashboard/Visualize\r\n<img width=\"1517\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/c8fb4faf-8d2d-4043-a757-6f092d1fceb3\">\r\n\r\n#### Stack Management > Data view\r\n<img width=\"1519\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/bb3f28bd-0ce9-4c49-ace1-1be875e17ba3\">\r\n\r\n#### If User does not have privilege to create a Data View\r\n<img width=\"1336\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/bb3f4cbc-8213-41c0-bf09-bd47a9d264e4\">\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] Use a new SVG resource for the ES|QL illustration\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n- [x] Any UI touched in this PR is usable by keyboard only (learn more\r\nabout [keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n- [ ] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n- [x] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [x] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by: Liam Thompson <32779855+leemthompo@users.noreply.github.com>\r\nCo-authored-by: Andrea Del Rio <delrio.andre@gmail.com>","sha":"56e1e68b307bc62445f04ae6f443f4854a308547","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:SharedUX","v8.16.0","backport:version"],"title":"[ES|QL] Present ES|QL as an equal to data views on the \"no data views\" screen","number":194077,"url":"https://github.com/elastic/kibana/pull/194077","mergeCommit":{"message":"[ES|QL] Present ES|QL as an equal to data views on the \"no data views\" screen (#194077)\n\n## Summary\r\n\r\nResolves https://github.com/elastic/kibana/issues/176291\r\n\r\n### Screenshots\r\n\r\n#### Discover/Dashboard/Visualize\r\n<img width=\"1517\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/c8fb4faf-8d2d-4043-a757-6f092d1fceb3\">\r\n\r\n#### Stack Management > Data view\r\n<img width=\"1519\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/bb3f28bd-0ce9-4c49-ace1-1be875e17ba3\">\r\n\r\n#### If User does not have privilege to create a Data View\r\n<img width=\"1336\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/bb3f4cbc-8213-41c0-bf09-bd47a9d264e4\">\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] Use a new SVG resource for the ES|QL illustration\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n- [x] Any UI touched in this PR is usable by keyboard only (learn more\r\nabout [keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n- [ ] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n- [x] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [x] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by: Liam Thompson <32779855+leemthompo@users.noreply.github.com>\r\nCo-authored-by: Andrea Del Rio <delrio.andre@gmail.com>","sha":"56e1e68b307bc62445f04ae6f443f4854a308547"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/194077","number":194077,"mergeCommit":{"message":"[ES|QL] Present ES|QL as an equal to data views on the \"no data views\" screen (#194077)\n\n## Summary\r\n\r\nResolves https://github.com/elastic/kibana/issues/176291\r\n\r\n### Screenshots\r\n\r\n#### Discover/Dashboard/Visualize\r\n<img width=\"1517\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/c8fb4faf-8d2d-4043-a757-6f092d1fceb3\">\r\n\r\n#### Stack Management > Data view\r\n<img width=\"1519\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/bb3f28bd-0ce9-4c49-ace1-1be875e17ba3\">\r\n\r\n#### If User does not have privilege to create a Data View\r\n<img width=\"1336\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/bb3f4cbc-8213-41c0-bf09-bd47a9d264e4\">\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] Use a new SVG resource for the ES|QL illustration\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n- [x] Any UI touched in this PR is usable by keyboard only (learn more\r\nabout [keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n- [ ] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n- [x] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [x] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by: Liam Thompson <32779855+leemthompo@users.noreply.github.com>\r\nCo-authored-by: Andrea Del Rio <delrio.andre@gmail.com>","sha":"56e1e68b307bc62445f04ae6f443f4854a308547"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Tim Sullivan <tsullivan@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #176291
Screenshots
Discover/Dashboard/Visualize
Stack Management > Data view
If User does not have privilege to create a Data View
Checklist
Delete any items that are not applicable to this PR.