Skip to content

[8.x] [Automatic Import] Add Error handling framework (#193577)#194017

Merged
kibanamachine merged 2 commits intoelastic:8.xfrom
kibanamachine:backport/8.x/pr-193577
Sep 26, 2024
Merged

[8.x] [Automatic Import] Add Error handling framework (#193577)#194017
kibanamachine merged 2 commits intoelastic:8.xfrom
kibanamachine:backport/8.x/pr-193577

Conversation

@kibanamachine
Copy link
Copy Markdown
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

## Release Note

Adds error handling framework that provides error message with more
context to user.

## Summary

Relates - [192916](elastic#192916)

This PR adds an error handling framework.
- Add Error classes for specific error scenarios.
- If the error caught is of the predefined Error type the `message` and
`errorCode` is sent back to UI from server.
- The original error message is used to track telemetry and the
errorCode can be translated into a User visible error.
- If there is any non-predefined error server still throws a
`badRequest` with the error message.

This PR also adds/updates the graph images for different langgraphs

## Screenshots for error messages
<img width="690" alt="image"
src="https://github.com/user-attachments/assets/bb848ce7-e474-4e4e-8d07-59b534c543ea">

<img width="691" alt="image"
src="https://github.com/user-attachments/assets/fbf4cf46-9bbe-4c37-aaaa-0ede1cdcba7c">

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

(cherry picked from commit 9fb6f55)
@kibanamachine kibanamachine added the backport This PR is a backport of another PR label Sep 25, 2024
@kibanamachine kibanamachine enabled auto-merge (squash) September 25, 2024 14:28
@bhapas bhapas added release_note:feature Makes this part of the condensed release notes Team:Security-Scalability Security Integrations Scalability Team Feature:AutomaticImport labels Sep 25, 2024
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/security-scalability (Team:Security-Scalability)

@bhapas bhapas added the enhancement New value added to drive a business result label Sep 25, 2024
@bhapas
Copy link
Copy Markdown
Contributor

bhapas commented Sep 26, 2024

@elasticmachine merge upstream

@kibana-ci
Copy link
Copy Markdown

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
integrationAssistant 947.9KB 948.8KB +919.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
integrationAssistant 7 8 +1

Total ESLint disabled count

id before after diff
integrationAssistant 12 13 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @bhapas

@kibanamachine kibanamachine merged commit a84d8cb into elastic:8.x Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR enhancement New value added to drive a business result Feature:AutomaticImport release_note:feature Makes this part of the condensed release notes Team:Security-Scalability Security Integrations Scalability Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants