[8.x] [Entity Analytics] Asset Criticality soft delete (#193591)#194010
Merged
kibanamachine merged 1 commit intoelastic:8.xfrom Sep 25, 2024
Merged
[8.x] [Entity Analytics] Asset Criticality soft delete (#193591)#194010kibanamachine merged 1 commit intoelastic:8.xfrom
kibanamachine merged 1 commit intoelastic:8.xfrom
Conversation
## Summary This PR introduces a "soft delete" for Asset Criticality records. Instead of deleting the document, we now simply change the criticality field to the value `"deleted"`. This value is fully managed on Kibana and should not be exposed to the client side. ### How to test 1. Add some host/user data 2. Make sure to enable the `entityStoreEnabled` feature flag 3. Assign asset criticality to a user/host. * You may need to enable Asset Criticality in Kibana Advanced Settings 5. Verify the criticality has been assigned by `GET .asset-citicality*`. 6. Unassign the criticality for that host/user via the UI. 7. `GET`ing the criticality index should now still show the updated record with `"deleted"` criticality value 8. The Ui should also show criticality as `Unassigned` for the deleted record. Implements elastic/security-team#10531, which is part of the overall [Entity Store for 8.16](elastic/security-team#10529) work (cherry picked from commit a8c7e06)
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
To update your PR or re-run it, just comment with: cc @tiansivive |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.x:Questions ?
Please refer to the Backport tool documentation