Fixing Torq hostname identifying logic by igorkheif · Pull Request #194003 · elastic/kibana

igorkheif · 2024-09-25T13:31:18Z

Summary

This change allows the connector to validate all of the Torq subdomains such as hooks.eu.torq.io instead of just the default hooks.torq.io.
This need arises as Torq now has several environments in various locations, and they all use different subdomains.

Checklist

Delete any items that are not applicable to this PR.

Unit or functional tests were updated or added to match the most common scenarios
Flaky Test Runner was used on any tests changed

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk	Probability	Severity	Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space.	Low	High	Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks.	High	Low	Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled.	Medium	High	Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

This was checked for breaking API changes and was labeled appropriately

cla-checker-service · 2024-09-25T13:31:23Z

💚 CLA has been signed

elasticmachine · 2024-09-25T13:51:55Z

Pinging @elastic/security-detection-engine (Team:Detection Alerts)

pmuellr · 2024-09-25T13:52:07Z

Is there an issue open for this? Not seeing one ...

pmuellr · 2024-09-25T17:46:08Z

I've added security-detections-response as a reviewer, as that team owns this code. After their review, response-ops will review ...

michaelolo24 · 2024-10-30T14:08:50Z

x-pack/plugins/stack_connectors/public/connector_types/torq/torq_utils.tsx

+    };
+    if (!isUrl(value)) return error;
+    const hostname = new URL(value).hostname;
+    const isTorqHostname = /^hooks(\.[a-z0-9]+)*\.torq\.io$/.test(hostname);


Looks like this was the only functional change in this PR. It looks good and the tests look great, thank you for adding them. Will leave the final review and approval to the @elastic/response-ops team as I'm not familiar with the torq.io url naming patterns. Thanks for the improvement @igorkheif !

cnasikas · 2024-11-19T07:34:14Z

@michaelolo24 @igorkheif Before reviewing we need the security solution team to review, test, and approve the PR. After that, we will do a high-level review. Could you also please update the description so reviewers unfamiliar with Torq will better understand what this PR is about? Thanks!

asnehalb · 2024-12-04T16:33:42Z

@igorkheif As Christos also mentioned above, could you please add more details to the description and also some steps/instructions for how to test the PR so reviewers unfamiliar with Torq will have a better understanding ?

michaelolo24 · 2024-12-05T15:06:01Z

@igorkheif - Thanks for making these changes. We were able to test it, and while the validation on the UI is working as expected, you'll also need to modify the server side validation as well:

kibana/x-pack/plugins/stack_connectors/server/connector_types/torq/index.ts

Line 131 in 3579425

    
           if (configureUrlObj.hostname !== 'hooks.torq.io' && configureUrlObj.hostname !== 'localhost') {

and please update the tests as well

michaelolo24

Please update the validation on the server as well:

kibana/x-pack/plugins/stack_connectors/server/connector_types/torq/index.ts

Line 131 in 3579425

    
           if (configureUrlObj.hostname !== 'hooks.torq.io' && configureUrlObj.hostname !== 'localhost') {

…to fix-torq-url

…q-url

igorkheif · 2025-02-03T12:58:23Z

@igorkheif - Thanks for making these changes. We were able to test it, and while the validation on the UI is working as expected, you'll also need to modify the server side validation as well:

kibana/x-pack/plugins/stack_connectors/server/connector_types/torq/index.ts

Line 131 in 3579425

if (configureUrlObj.hostname !== 'hooks.torq.io' && configureUrlObj.hostname !== 'localhost') {

and please update the tests as well

@michaelolo24 Thanks, good catch! Done!

michaelolo24 · 2025-02-11T15:00:34Z

@elasticmachine merge upstream

Zacqary

LGTM from Response Ops side, thanks @igorkheif

elasticmachine · 2025-03-04T07:48:41Z

Pinging @elastic/response-ops (Team:ResponseOps)

cnasikas · 2025-03-04T07:48:56Z

@elasticmachine merge upstream

semd · 2025-03-07T18:04:53Z

This has already been implemented in #212563. Closing this one.
Thanks!

Fixing Torq hostname identifying logic

c5d62e0

igorkheif requested a review from a team as a code owner September 25, 2024 13:31

kibanamachine added the 💝community label Sep 25, 2024

pmuellr added the Team:Detection Alerts Security Detection Alerts Area Team label Sep 25, 2024

pmuellr requested a review from a team September 25, 2024 17:44

removing unneeded blank space

e7e09db

cnasikas added backport:skip This PR does not require backporting backport:prev-minor labels Oct 14, 2024

igorkheif added 3 commits October 21, 2024 12:42

moviing TorqWebhookEndpoint to utils file and adding tests

f225d42

Merge branch 'main' into fix-torq-url

6db297c

Merge branch 'main' into fix-torq-url

1718211

michaelolo24 reviewed Oct 30, 2024

View reviewed changes

michaelolo24 requested changes Dec 5, 2024

View reviewed changes

igorkheif added 2 commits February 3, 2025 14:34

fixing serverside support for Torq subdomain webhook URLs

169c994

Merge branch 'fix-torq-url' of https://github.com/igorkheif/kibana in…

f5fa6b6

…to fix-torq-url

igorkheif requested a review from michaelolo24 February 3, 2025 12:37

Merge branch 'main' of https://github.com/elastic/kibana into fix-tor…

46e1177

…q-url

Merge branch 'main' into fix-torq-url

faf214b

michaelolo24 added the release_note:enhancement label Feb 11, 2025

igorkheif and others added 2 commits February 20, 2025 09:30

Merge branch 'main' into fix-torq-url

1a79768

Merge branch 'main' into fix-torq-url

e2e8e11

michaelolo24 approved these changes Mar 3, 2025

View reviewed changes

Zacqary approved these changes Mar 3, 2025

View reviewed changes

Merge branch 'main' into fix-torq-url

a09a1cc

Zacqary enabled auto-merge (squash) March 3, 2025 17:10

Merge branch 'main' into fix-torq-url

dd38f43

semd closed this Mar 7, 2025

auto-merge was automatically disabled March 7, 2025 18:04
Pull request was closed

Conversation

igorkheif commented Sep 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

Risk Matrix

For maintainers

Uh oh!

cla-checker-service bot commented Sep 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

elasticmachine commented Sep 25, 2024

Uh oh!

pmuellr commented Sep 25, 2024

Uh oh!

pmuellr commented Sep 25, 2024

Uh oh!

michaelolo24 Oct 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cnasikas commented Nov 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

asnehalb commented Dec 4, 2024

Uh oh!

michaelolo24 commented Dec 5, 2024

Uh oh!

michaelolo24 left a comment

Choose a reason for hiding this comment

Uh oh!

igorkheif commented Feb 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

michaelolo24 commented Feb 11, 2025

Uh oh!

Zacqary left a comment

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Mar 4, 2025

Uh oh!

cnasikas commented Mar 4, 2025

Uh oh!

semd commented Mar 7, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

igorkheif commented Sep 25, 2024 •

edited

Loading

cla-checker-service bot commented Sep 25, 2024 •

edited

Loading

michaelolo24 Oct 30, 2024 •

edited

Loading

cnasikas commented Nov 19, 2024 •

edited

Loading

igorkheif commented Feb 3, 2025 •

edited

Loading