Skip to content

Fix type issue resulting from #193415 & #193791#193970

Merged
delanni merged 1 commit intomainfrom
fix-type-issue-20240925
Sep 25, 2024
Merged

Fix type issue resulting from #193415 & #193791#193970
delanni merged 1 commit intomainfrom
fix-type-issue-20240925

Conversation

@delanni
Copy link
Copy Markdown
Member

@delanni delanni commented Sep 25, 2024

Summary

As the title says. Two competing changes made it in to main (#193415 & #193791), causing a type issue: https://buildkite.com/elastic/kibana-on-merge/builds/50786#019228ae-4487-45c6-867a-ba0590b1266d

cc: @davismcphee @stratoula

@delanni delanni added release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor labels Sep 25, 2024
@delanni delanni marked this pull request as ready for review September 25, 2024 11:03
@delanni delanni requested review from a team as code owners September 25, 2024 11:03
@stratoula
Copy link
Copy Markdown
Contributor

Thanx Alex for the PR! @davismcphee know the changes in both PRs better than me but the change makes sense to me!

Copy link
Copy Markdown
Contributor

@jughosta jughosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge, thanks! 👍

@kibana-ci
Copy link
Copy Markdown

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Integration Tests #3 / when rolling back to an older version kibana should detect that a later version alias exists, and abort

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cloudSecurityPosture 497.7KB 497.7KB +18.0B
discover 813.8KB 813.9KB +18.0B
esqlDataGrid 154.0KB 154.0KB +18.0B
securitySolution 20.4MB 20.4MB +90.0B
slo 855.1KB 855.1KB +18.0B
total +162.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@delanni delanni merged commit 6c1f18c into main Sep 25, 2024
@delanni delanni deleted the fix-type-issue-20240925 branch September 25, 2024 12:24
@kibanamachine
Copy link
Copy Markdown
Contributor

💔 All backports failed

Status Branch Result
8.x Backport failed because of merge conflicts

You might need to backport the following PRs to 8.x:
- [[ES

Manual backport

To create the backport manually run:

node scripts/backport --pr 193970

Questions ?

Please refer to the Backport tool documentation

This was referenced Sep 25, 2024
@delanni delanni added backport:skip This PR does not require backporting and removed backport:prev-minor labels Sep 25, 2024
@delanni
Copy link
Copy Markdown
Member Author

delanni commented Sep 25, 2024

Backport not needed, as types are fixed in: #193962

@kertal
Copy link
Copy Markdown
Member

kertal commented Sep 25, 2024

@delanni thx for cleaning/closing all those test failures

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes v9.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants