Skip to content

[TableListView] Adjust last updated date format#193964

Merged
Dosant merged 2 commits intoelastic:mainfrom
Dosant:d/fix-column-width
Sep 25, 2024
Merged

[TableListView] Adjust last updated date format#193964
Dosant merged 2 commits intoelastic:mainfrom
Dosant:d/fix-column-width

Conversation

@Dosant
Copy link
Copy Markdown
Contributor

@Dosant Dosant commented Sep 25, 2024

Summary

I noticed that "september" doesn't look nice as it wraps:

Screenshot 2024-09-25 at 12 37 00

I suggest we use a shorter format:

Screenshot 2024-09-25 at 12 36 48

@Dosant Dosant added release_note:skip Skip the PR/issue when compiling release notes Team:SharedUX Platform AppEx-SharedUX (formerly Global Experience) t// backport:prev-minor Component:TableListView labels Sep 25, 2024
@Dosant Dosant requested a review from a team as a code owner September 25, 2024 10:39
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

Copy link
Copy Markdown
Contributor

@sebelga sebelga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Dosant
Copy link
Copy Markdown
Contributor Author

Dosant commented Sep 25, 2024

@elasticmachine merge upstream

1 similar comment
@Dosant
Copy link
Copy Markdown
Contributor Author

Dosant commented Sep 25, 2024

@elasticmachine merge upstream

@Dosant Dosant enabled auto-merge (squash) September 25, 2024 15:17
@kibana-ci
Copy link
Copy Markdown

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #1 / DeleteAttachmentConfirmationModal calls onConfirm

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@Dosant Dosant merged commit b6e692c into elastic:main Sep 25, 2024
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 25, 2024
## Summary

I noticed that "september" doesn't look nice as it wraps:

![Screenshot 2024-09-25 at 12 37
00](https://github.com/user-attachments/assets/9ca4a85b-bcde-4228-9c58-9cddb7f89945)

I suggest we use a shorter format:

![Screenshot 2024-09-25 at 12 36
48](https://github.com/user-attachments/assets/3f2b2111-c1d9-4bae-a139-bd9ea6e38fc4)

(cherry picked from commit b6e692c)
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Sep 25, 2024
)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[TableListView] Adjust last updated date format
(#193964)](#193964)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Anton
Dosov","email":"anton.dosov@elastic.co"},"sourceCommit":{"committedDate":"2024-09-25T17:00:53Z","message":"[TableListView]
Adjust last updated date format (#193964)\n\n## Summary\r\n\r\nI noticed
that \"september\" doesn't look nice as it wraps: \r\n\r\n![Screenshot
2024-09-25 at 12
37\r\n00](https://github.com/user-attachments/assets/9ca4a85b-bcde-4228-9c58-9cddb7f89945)\r\n\r\nI
suggest we use a shorter format: \r\n\r\n![Screenshot 2024-09-25 at 12
36\r\n48](https://github.com/user-attachments/assets/3f2b2111-c1d9-4bae-a139-bd9ea6e38fc4)","sha":"b6e692ccb05a3e5a2b8747b4d5f21d0d8a235d52","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:SharedUX","backport:prev-minor","Component:TableListView"],"title":"[TableListView]
Adjust last updated date
format","number":193964,"url":"https://github.com/elastic/kibana/pull/193964","mergeCommit":{"message":"[TableListView]
Adjust last updated date format (#193964)\n\n## Summary\r\n\r\nI noticed
that \"september\" doesn't look nice as it wraps: \r\n\r\n![Screenshot
2024-09-25 at 12
37\r\n00](https://github.com/user-attachments/assets/9ca4a85b-bcde-4228-9c58-9cddb7f89945)\r\n\r\nI
suggest we use a shorter format: \r\n\r\n![Screenshot 2024-09-25 at 12
36\r\n48](https://github.com/user-attachments/assets/3f2b2111-c1d9-4bae-a139-bd9ea6e38fc4)","sha":"b6e692ccb05a3e5a2b8747b4d5f21d0d8a235d52"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193964","number":193964,"mergeCommit":{"message":"[TableListView]
Adjust last updated date format (#193964)\n\n## Summary\r\n\r\nI noticed
that \"september\" doesn't look nice as it wraps: \r\n\r\n![Screenshot
2024-09-25 at 12
37\r\n00](https://github.com/user-attachments/assets/9ca4a85b-bcde-4228-9c58-9cddb7f89945)\r\n\r\nI
suggest we use a shorter format: \r\n\r\n![Screenshot 2024-09-25 at 12
36\r\n48](https://github.com/user-attachments/assets/3f2b2111-c1d9-4bae-a139-bd9ea6e38fc4)","sha":"b6e692ccb05a3e5a2b8747b4d5f21d0d8a235d52"}}]}]
BACKPORT-->

Co-authored-by: Anton Dosov <anton.dosov@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component:TableListView release_note:skip Skip the PR/issue when compiling release notes Team:SharedUX Platform AppEx-SharedUX (formerly Global Experience) t// v8.16.0 v9.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants